From e70b8791821f51bb0620ff04c622074c6ec9caaa Mon Sep 17 00:00:00 2001 From: link2xt Date: Thu, 17 Oct 2024 10:48:53 +0000 Subject: [PATCH] test: make test_verified_group_member_added_recovery more reliable To avoid reordering, wait for "member removed" message to be received before sending "member added". The test failed at least once because email server may reorder the messages internally while delivering. --- deltachat-rpc-client/tests/test_securejoin.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/deltachat-rpc-client/tests/test_securejoin.py b/deltachat-rpc-client/tests/test_securejoin.py index 4a5421bc2..6247a6cdb 100644 --- a/deltachat-rpc-client/tests/test_securejoin.py +++ b/deltachat-rpc-client/tests/test_securejoin.py @@ -325,7 +325,6 @@ def test_verified_group_member_added_recovery(acfactory) -> None: ac3_contact_ac2 = ac3.get_contact_by_addr(ac2.get_config("addr")) ac3_chat.remove_contact(ac3_contact_ac2) - ac3_chat.add_contact(ac3_contact_ac2) msg_id = ac2.wait_for_incoming_msg_event().msg_id message = ac2.get_message_by_id(msg_id) @@ -335,6 +334,8 @@ def test_verified_group_member_added_recovery(acfactory) -> None: snapshot = ac1.get_message_by_id(ac1.wait_for_incoming_msg_event().msg_id).get_snapshot() assert "removed" in snapshot.text + ac3_chat.add_contact(ac3_contact_ac2) + event = ac2.wait_for_incoming_msg_event() msg_id = event.msg_id chat_id = event.chat_id