From e45747ea991001760d97123096d2614985d7339e Mon Sep 17 00:00:00 2001 From: Hocuri Date: Sat, 15 Oct 2022 10:11:57 +0200 Subject: [PATCH] small fixes --- src/authres_handling.rs | 3 --- src/decrypt.rs | 2 -- src/mimeparser.rs | 3 --- 3 files changed, 8 deletions(-) diff --git a/src/authres_handling.rs b/src/authres_handling.rs index 3f7cfc785..8492169ca 100644 --- a/src/authres_handling.rs +++ b/src/authres_handling.rs @@ -79,7 +79,6 @@ fn parse_authres_headers( // with providers not implementing the RFC correctly, someone can trick us // into thinking that an incoming email is DKIM-correct, anyway. // The most important thing here is that we have some valid `authserv_id`. - // TODO is this comment understandable? authserv_id = "invalidAuthservId"; } let dkim_passed = parse_one_authres_header(&header_value, from_domain); @@ -537,8 +536,6 @@ Authentication-Results: box.hispanilandia.net; spf=pass smtp.mailfrom=adbenitez@ println!("From {}: {}", from_domain, dkim_result); } } - - std::mem::forget(t) // TODO dbg } assert!(!test_failed); diff --git a/src/decrypt.rs b/src/decrypt.rs index 21090b113..4984846bf 100644 --- a/src/decrypt.rs +++ b/src/decrypt.rs @@ -3,7 +3,6 @@ use std::collections::HashSet; use anyhow::{Context as _, Result}; - use mailparse::ParsedMail; use mailparse::SingleInfo; @@ -11,7 +10,6 @@ use crate::aheader::Aheader; use crate::authres_handling::handle_authres; use crate::contact::addr_cmp; use crate::context::Context; - use crate::key::{DcKey, Fingerprint, SignedPublicKey, SignedSecretKey}; use crate::keyring::Keyring; use crate::log::LogExt; diff --git a/src/mimeparser.rs b/src/mimeparser.rs index 9f069b154..90571058d 100644 --- a/src/mimeparser.rs +++ b/src/mimeparser.rs @@ -7,7 +7,6 @@ use std::pin::Pin; use anyhow::{bail, Context as _, Result}; use deltachat_derive::{FromSql, ToSql}; use lettre_email::mime::{self, Mime}; - use mailparse::{addrparse_header, DispositionType, MailHeader, MailHeaderMap, SingleInfo}; use once_cell::sync::Lazy; @@ -90,7 +89,6 @@ pub struct MimeMessage { pub decoded_data: Vec, pub(crate) hop_info: String, - //pub(crate) authentication_results: HashMap, // TODO } #[derive(Debug, PartialEq)] @@ -338,7 +336,6 @@ impl MimeMessage { is_mime_modified: false, decoded_data: Vec::new(), hop_info, - //authentication_results, }; match partial {