From e318f5c6979c16183beb54933c49ba1d4efe49e1 Mon Sep 17 00:00:00 2001 From: link2xt Date: Tue, 31 Jan 2023 23:58:38 +0000 Subject: [PATCH] Simplify unset_empty() --- src/login_param.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/login_param.rs b/src/login_param.rs index 36f0a879f..297ffa77f 100644 --- a/src/login_param.rs +++ b/src/login_param.rs @@ -1,6 +1,5 @@ //! # Login parameters. -use std::borrow::Cow; use std::fmt; use anyhow::{ensure, Result}; @@ -298,12 +297,11 @@ impl fmt::Display for LoginParam { } } -#[allow(clippy::ptr_arg)] -fn unset_empty(s: &String) -> Cow { +fn unset_empty(s: &str) -> &str { if s.is_empty() { - Cow::Owned("unset".to_string()) + "unset" } else { - Cow::Borrowed(s) + s } }