diff --git a/src/chat.rs b/src/chat.rs index 5032230eb..1f3238262 100644 --- a/src/chat.rs +++ b/src/chat.rs @@ -1218,12 +1218,11 @@ impl ChatId { ) .await? } else if received { - // Received messages shouldn't mingle with just sent ones and appear somewhere in the - // middle of the chat, so we go after the newest non fresh message. - // - // But if a received outgoing message is older than some seen message, better sort the - // received message purely by timestamp. We could place it just before that seen - // message, but anyway the user may not notice it. + // Received incoming messages shouldn't mingle with just sent ones and appear somewhere + // in the middle of the chat, so we go after the newest non fresh message. Received + // outgoing messages are allowed to mingle with seen messages though to avoid seen + // replies appearing before messages sent from another device (cases like the user + // sharing the account with others or bots are rare, so let them break sometimes). // // NB: Received outgoing messages may break sorting of fresh incoming ones, but this // shouldn't happen frequently. Seen incoming messages don't really break sorting of @@ -1231,24 +1230,23 @@ impl ChatId { context .sql .query_row_optional( - "SELECT MAX(timestamp), MAX(IIF(state=?,timestamp_sent,0)) + "SELECT MAX(timestamp) FROM msgs WHERE chat_id=? AND hidden=0 AND state>? HAVING COUNT(*) > 0", - (MessageState::InSeen, self, MessageState::InFresh), + ( + self, + match incoming { + true => MessageState::InFresh, + false => MessageState::InSeen, + }, + ), |row| { let ts: i64 = row.get(0)?; - let ts_sent_seen: i64 = row.get(1)?; - Ok((ts, ts_sent_seen)) + Ok(ts) }, ) .await? - .and_then(|(ts, ts_sent_seen)| { - match incoming || ts_sent_seen <= message_timestamp { - true => Some(ts), - false => None, - } - }) } else { None }; diff --git a/test-data/golden/test_outgoing_encrypted_msg b/test-data/golden/test_outgoing_encrypted_msg index cf7625803..8accbb96b 100644 --- a/test-data/golden/test_outgoing_encrypted_msg +++ b/test-data/golden/test_outgoing_encrypted_msg @@ -1,5 +1,5 @@ Single#Chat#10: bob@example.net [KEY bob@example.net] -------------------------------------------------------------------------------- -Msg#10: info (Contact#Contact#Info): Messages are end-to-end encrypted. [NOTICED][INFO] Msg#11🔒: Me (Contact#Contact#Self): Test – This is encrypted, signed, and has an Autocrypt Header without prefer-encrypt=mutual. √ +Msg#10: info (Contact#Contact#Info): Messages are end-to-end encrypted. [NOTICED][INFO] --------------------------------------------------------------------------------