From e14265ec5d0b05e76df3fe35a46602f5b8dd205b Mon Sep 17 00:00:00 2001 From: iequidoo Date: Thu, 4 Sep 2025 03:15:11 -0300 Subject: [PATCH] refactor: Remove test-data/golden/test_old_message_5 It just records the current questionable behavior which is better to explain in the comment within the test. Also remove the comment about "sentbox" as we don't want to support watching Sentbox anymore. --- src/tests/verified_chats.rs | 13 ++++++------- test-data/golden/test_old_message_5 | 5 ----- 2 files changed, 6 insertions(+), 12 deletions(-) delete mode 100644 test-data/golden/test_old_message_5 diff --git a/src/tests/verified_chats.rs b/src/tests/verified_chats.rs index 2a85dbc02..90465fdab 100644 --- a/src/tests/verified_chats.rs +++ b/src/tests/verified_chats.rs @@ -316,9 +316,8 @@ async fn test_old_message_4() -> Result<()> { Ok(()) } -/// Alice is offline for some time. -/// When they come online, first their sentbox is synced and then their inbox. -/// This test tests that the messages are still in the right order. +/// Alice's device#0 is offline for some time. +/// When it comes online, it sees a message from another device and an incoming message. #[tokio::test(flavor = "multi_thread", worker_threads = 2)] async fn test_old_message_5() -> Result<()> { let alice = TestContext::new_alice().await; @@ -348,11 +347,11 @@ async fn test_old_message_5() -> Result<()> { .await? .unwrap(); + // It's not clear what we want here: if `msg_sent` is sent by Alice, it better to sort + // `msg_incoming` after it so that it's more visible (current behavior), but if Alice shares her + // account with someone else or has some auto-reply bot, messages should be sorted just by + // "Date". assert!(msg_sent.sort_timestamp == msg_incoming.sort_timestamp); - alice - .golden_test_chat(msg_sent.chat_id, "test_old_message_5") - .await; - Ok(()) } diff --git a/test-data/golden/test_old_message_5 b/test-data/golden/test_old_message_5 deleted file mode 100644 index 624838a43..000000000 --- a/test-data/golden/test_old_message_5 +++ /dev/null @@ -1,5 +0,0 @@ -Single#Chat#10: Bob [bob@example.net] Icon: 4138c52e5bc1c576cda7dd44d088c07.png --------------------------------------------------------------------------------- -Msg#10: Me (Contact#Contact#Self): Happy birthday, Bob! √ -Msg#11: (Contact#Contact#10): Happy birthday to me, Alice! [FRESH] ---------------------------------------------------------------------------------