diff --git a/examples/repl/cmdline.rs b/examples/repl/cmdline.rs index ca9d8de57..181f9ebd0 100644 --- a/examples/repl/cmdline.rs +++ b/examples/repl/cmdline.rs @@ -132,10 +132,8 @@ fn poke_spec(context: &Context, spec: *const libc::c_char) -> libc::c_int { real_spec = rs.unwrap(); } if let Some(suffix) = dc_get_filesuffix_lc(&real_spec) { - if suffix == "eml" { - if dc_poke_eml_file(context, &real_spec).is_ok() { - read_cnt += 1 - } + if suffix == "eml" && dc_poke_eml_file(context, &real_spec).is_ok() { + read_cnt += 1 } } else { /* import a directory */ @@ -588,7 +586,7 @@ pub unsafe fn dc_cmdline(context: &Context, line: &str) -> Result<(), failure::E let members = chat::get_chat_contacts(context, sel_chat.id); let subtitle = if sel_chat.is_device_talk() { "device-talk".to_string() - } else if sel_chat.get_type() == Chattype::Single && members.len() >= 1 { + } else if sel_chat.get_type() == Chattype::Single && !members.is_empty() { let contact = Contact::get_by_id(context, members[0])?; contact.get_addr().to_string() } else { @@ -862,11 +860,7 @@ pub unsafe fn dc_cmdline(context: &Context, line: &str) -> Result<(), failure::E "archive" | "unarchive" => { ensure!(!arg1.is_empty(), "Argument missing."); let chat_id = arg1.parse()?; - chat::archive( - context, - chat_id, - if arg0 == "archive" { true } else { false }, - )?; + chat::archive(context, chat_id, arg0 == "archive")?; } "delchat" => { ensure!(!arg1.is_empty(), "Argument missing."); diff --git a/examples/repl/main.rs b/examples/repl/main.rs index c1e855cfb..bc7528c5d 100644 --- a/examples/repl/main.rs +++ b/examples/repl/main.rs @@ -235,7 +235,7 @@ impl Completer for DcHelper { } } -const IMEX_COMMANDS: [&'static str; 12] = [ +const IMEX_COMMANDS: [&str; 12] = [ "initiate-key-transfer", "get-setupcodebegin", "continue-key-transfer", @@ -250,7 +250,7 @@ const IMEX_COMMANDS: [&'static str; 12] = [ "stop", ]; -const DB_COMMANDS: [&'static str; 11] = [ +const DB_COMMANDS: [&str; 11] = [ "info", "open", "close", @@ -264,7 +264,7 @@ const DB_COMMANDS: [&'static str; 11] = [ "housekeeping", ]; -const CHAT_COMMANDS: [&'static str; 24] = [ +const CHAT_COMMANDS: [&str; 24] = [ "listchats", "listarchived", "chat", @@ -290,7 +290,7 @@ const CHAT_COMMANDS: [&'static str; 24] = [ "unarchive", "delchat", ]; -const MESSAGE_COMMANDS: [&'static str; 8] = [ +const MESSAGE_COMMANDS: [&str; 8] = [ "listmsgs", "msginfo", "listfresh", @@ -300,7 +300,7 @@ const MESSAGE_COMMANDS: [&'static str; 8] = [ "unstar", "delmsg", ]; -const CONTACT_COMMANDS: [&'static str; 6] = [ +const CONTACT_COMMANDS: [&str; 6] = [ "listcontacts", "listverified", "addcontact", @@ -308,7 +308,7 @@ const CONTACT_COMMANDS: [&'static str; 6] = [ "delcontact", "cleanupcontacts", ]; -const MISC_COMMANDS: [&'static str; 9] = [ +const MISC_COMMANDS: [&str; 9] = [ "getqr", "getbadqr", "checkqr", "event", "fileinfo", "clear", "exit", "quit", "help", ]; @@ -334,8 +334,8 @@ impl Hinter for DcHelper { } } -static COLORED_PROMPT: &'static str = "\x1b[1;32m> \x1b[0m"; -static PROMPT: &'static str = "> "; +static COLORED_PROMPT: &str = "\x1b[1;32m> \x1b[0m"; +static PROMPT: &str = "> "; impl Highlighter for DcHelper { fn highlight_prompt<'p>(&self, prompt: &'p str) -> Cow<'p, str> { diff --git a/examples/simple.rs b/examples/simple.rs index 9fe8ade26..67c8fbbc7 100644 --- a/examples/simple.rs +++ b/examples/simple.rs @@ -113,7 +113,7 @@ fn main() { println!("stopping threads"); - *running.clone().write().unwrap() = false; + *running.write().unwrap() = false; deltachat::job::interrupt_inbox_idle(&ctx, true); deltachat::job::interrupt_smtp_idle(&ctx); diff --git a/tests/stress.rs b/tests/stress.rs index af3ff455d..5ce1b8e45 100644 --- a/tests/stress.rs +++ b/tests/stress.rs @@ -128,7 +128,7 @@ fn test_encryption_decryption() { public_keyring.add_ref(&public_key); let mut public_keyring2 = Keyring::default(); - public_keyring2.add_owned(public_key2.clone()); + public_keyring2.add_owned(public_key2); let mut valid_signatures: HashSet = Default::default(); @@ -220,7 +220,7 @@ fn create_test_context() -> TestContext { let dir = tempdir().unwrap(); let dbfile = dir.path().join("db.sqlite"); let ctx = Context::new(Box::new(cb), "FakeOs".into(), dbfile).unwrap(); - TestContext { ctx: ctx, dir: dir } + TestContext { ctx, dir } } #[test]