Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-04-27 10:26:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Only scan on the Inbox thread

Browse Source 
This should prevent race conditions when multiple threads fetch at once.
This commit is contained in:
Hocuri
2021-02-14 11:05:04 +01:00
parent a88893f262
commit c92367088f
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/scheduler.rs
View File

@@ -96,6 +96,9 @@ async fn inbox_loop(ctx: Context, started: Sender<()>, inbox_handlers: ImapConne
info = if ctx.get_config_bool(Config::InboxWatch).await { info = if ctx.get_config_bool(Config::InboxWatch).await {
fetch_idle(&ctx, &mut connection, Config::ConfiguredInboxFolder).await fetch_idle(&ctx, &mut connection, Config::ConfiguredInboxFolder).await
} else { } else {
if let Err(err) = connection.scan_folders(&ctx).await {
warn!(ctx, "{}", err);
}
connection.fake_idle(&ctx, None).await connection.fake_idle(&ctx, None).await
}; };
} }
@@ -152,11 +155,14 @@ async fn fetch_idle(ctx: &Context, connection: &mut Imap, folder: Config) -> Int
warn!(ctx, "{:#}", err); warn!(ctx, "{:#}", err);
} }
if folder == Config::ConfiguredInboxFolder {
// Only scan on the Inbox thread in order to prevent parallel scans, which might lead to duplicate messages
if let Err(err) = connection.scan_folders(ctx).await { if let Err(err) = connection.scan_folders(ctx).await {
// Don't reconnect, if there is a problem with the connection we will realize this when IDLEing // Don't reconnect, if there is a problem with the connection we will realize this when IDLEing
// but maybe just one folder can't be selected or something // but maybe just one folder can't be selected or something
warn!(ctx, "{}", err); warn!(ctx, "{}", err);
} }
}
// idle // idle
if connection.can_idle() { if connection.can_idle() {