From c36227e2fcf606307f834816e707a78f4aa1f318 Mon Sep 17 00:00:00 2001 From: Alexander Krotov Date: Sun, 10 May 2020 23:16:38 +0300 Subject: [PATCH] Better SMTP ErrorNetwork message It uses stock string, just as for IMAP errors, and is distinguishable from IMAP errors: protocol is specified in the error message now. --- src/imap/mod.rs | 2 +- src/smtp/mod.rs | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/imap/mod.rs b/src/imap/mod.rs index 3c90f235a..789ef02b2 100644 --- a/src/imap/mod.rs +++ b/src/imap/mod.rs @@ -269,7 +269,7 @@ impl Imap { let imap_port = config.imap_port; context.stock_string_repl_str2( StockMessage::ServerResponse, - format!("{}:{}", imap_server, imap_port), + format!("IMAP {}:{}", imap_server, imap_port), err.to_string(), ) }; diff --git a/src/smtp/mod.rs b/src/smtp/mod.rs index 83f9106e3..b8e698087 100644 --- a/src/smtp/mod.rs +++ b/src/smtp/mod.rs @@ -12,6 +12,7 @@ use crate::context::Context; use crate::events::Event; use crate::login_param::{dc_build_tls, LoginParam}; use crate::oauth2::*; +use crate::stock::StockMessage; /// SMTP write and read timeout in seconds. const SMTP_TIMEOUT: u64 = 30; @@ -171,7 +172,14 @@ impl Smtp { let mut trans = client.into_transport(); trans.connect().await.map_err(|err| { - emit_event!(context, Event::ErrorNetwork(err.to_string())); + let message = { + context.stock_string_repl_str2( + StockMessage::ServerResponse, + format!("SMTP {}:{}", domain, port), + err.to_string(), + ) + }; + emit_event!(context, Event::ErrorNetwork(message)); Error::ConnectionFailure(err) })?;