Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-04-28 19:06:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

test(rpc-client): Replace remaining print()s with logging (#6082)

Browse Source 
This is to fix tests failing with `OSError: [Errno 9] Bad file descriptor`. Maybe stdout closes
earlier than stderr, before the test finishes, not sure. For reference, the previous commit removing
print()s is 800edc6fce.
This commit is contained in:
iequidoo
2026-01-09 11:57:44 -03:00
committed by iequidoo
parent c06f53cb86
commit ba4055b7df
3 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
deltachat-rpc-client/tests/conftest.py
View File

@@ -2,6 +2,7 @@ from __future__ import annotations
import imaplib
import io
import logging
import pathlib
import ssl
from contextlib import contextmanager
@@ -45,13 +46,13 @@ class DirectImap:
try:
self.conn.logout()
except (OSError, imaplib.IMAP4.abort):
print("Could not logout direct_imap conn")
logging.warning("Could not logout direct_imap conn")
def create_folder(self, foldername):
try:
self.conn.folder.create(foldername)
except errors.MailboxFolderCreateError as e:
print("Can't create", foldername, "probably it already exists:", str(e))
logging.warning(f"Cannot create '{foldername}', probably it already exists: {str(e)}")
def select_folder(self, foldername: str) -> tuple:
assert not self._idling
@@ -95,7 +96,7 @@ class DirectImap:
messages = self.get_unread_messages()
if messages:
res = self.conn.flag(messages, MailMessageFlags.SEEN, True)
print("marked seen:", messages, res)
logging.info(f"Marked seen: {messages} {res}")
def get_unread_cnt(self) -> int:
return len(self.get_unread_messages())

4
deltachat-rpc-client/tests/test_something.py
View File

@@ -370,13 +370,13 @@ def test_selfavatar_sync(acfactory, data, log) -> None:
alice.set_config("selfavatar", image)
avatar_config = alice.get_config("selfavatar")
avatar_hash = os.path.basename(avatar_config)
print("Info: avatar hash is ", avatar_hash)
logging.info(f"Avatar hash is {avatar_hash}")
log.section("First device receives avatar change")
alice2.wait_for_event(EventType.SELFAVATAR_CHANGED)
avatar_config2 = alice2.get_config("selfavatar")
avatar_hash2 = os.path.basename(avatar_config2)
print("Info: avatar hash on second device is ", avatar_hash2)
logging.info(f"Avatar hash on second device is {avatar_hash2}")
assert avatar_hash == avatar_hash2
assert avatar_config != avatar_config2