Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-04-18 05:56:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

Check DKIM Authentication-Results (#3583)

Browse Source 
Fix #3507

Note that this is not intended for a release at this point! We first have to test whether it runs stable enough. If we want to make a release while we are not confident enough in authres-checking, then we have to disable it.

BTW, most of the 3000 new lines are in `test_data/messages/dkimchecks...`, not the actual code

da3a4b94 adds the results to the Message info. It currently does this by adding them to `hop_info`. Maybe we should rename `hop_info` to `extra_info` or something; this has the disadvantage that we can't rename the sql column name though.

Follow-ups for this could be:
- In `update_authservid_candidates()`: Implement the rest of the algorithm @hpk42 and me thought about. What's missing is remembering how sure we are that these are the right authserv-ids. Esp., when receiving a message sent from another account at the same domain, we can be quite sure that the authserv-ids in there are the ones of our email server. This will make authres-checking work with buzon.uy, disroot.org, yandex.ru, mailo.com, and riseup.net.
- Think about how we present this to the user - e.g. currently the only change is that we don't accept key changes, which will mean that the small lock on the message is not shown.
- And it will mean that we can fully enable AEAP, after revisiting the security implications of this, and assuming everyone (esp. @link2xt who pointed out the problems in the first place) feels comfortable with it.
This commit is contained in:
Hocuri
2022-10-28 12:15:37 +02:00
committed by GitHub
parent d8bc3769a5
commit b1c6c40fa7
326 changed files with 3304 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test-data/message/dkimchecks-2022-09-28/alice@fastmail.com/alice@mail.ru Normal file
View File

@@ -0,0 +1,34 @@
ARC-Authentication-Results: i=1; mx3.messagingengine.com;
x-csa=none;
x-me-sender=none;
x-ptr=pass smtp.helo=smtpng1.i.mail.ru policy.ptr=smtpng1.i.mail.ru;
bimi=none (No BIMI records found);
arc=none (no signatures found);
dkim=pass (2048-bit rsa key sha256) header.d=mail.ru header.i=@mail.ru
header.b=0EDw+VrK header.a=rsa-sha256 header.s=mail4 x-bits=2048;
dmarc=pass policy.published-domain-policy=reject
policy.applied-disposition=none policy.evaluated-disposition=none
(p=reject,d=none,d.eval=none) policy.policy-from=p
header.from=mail.ru;
iprev=pass smtp.remote-ip=94.100.181.251 (smtpng1.i.mail.ru);
spf=pass smtp.mailfrom=alice@mail.ru smtp.helo=smtpng1.i.mail.ru
Authentication-Results: mx3.messagingengine.com;
x-csa=none;
x-me-sender=none;
x-ptr=pass smtp.helo=smtpng1.i.mail.ru policy.ptr=smtpng1.i.mail.ru
Authentication-Results: mx3.messagingengine.com;
bimi=none (No BIMI records found)
Authentication-Results: mx3.messagingengine.com;
arc=none (no signatures found)
Authentication-Results: mx3.messagingengine.com;
dkim=pass (2048-bit rsa key sha256) header.d=mail.ru header.i=@mail.ru
header.b=0EDw+VrK header.a=rsa-sha256 header.s=mail4 x-bits=2048;
dmarc=pass policy.published-domain-policy=reject
policy.applied-disposition=none policy.evaluated-disposition=none
(p=reject,d=none,d.eval=none) policy.policy-from=p
header.from=mail.ru;
iprev=pass smtp.remote-ip=94.100.181.251 (smtpng1.i.mail.ru);
spf=pass smtp.mailfrom=alice@mail.ru smtp.helo=smtpng1.i.mail.ru
From: <alice@mail.ru>
To: <alice@fastmail.com>
Authentication-Results: smtpng1.m.smailru.net; auth=pass smtp.auth=alice@mail.ru smtp.mailfrom=alice@mail.ru