Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-04-21 15:36:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat: delete_msgs: Use transaction() instead of call_write()

Browse Source 
Explicit transaction does the only commit (and fsync()).
This commit is contained in:
iequidoo
2024-12-23 13:59:57 -03:00
committed by iequidoo
parent 3d5e442145
commit a910808b4e
2 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/location.rs
View File

@@ -707,9 +707,6 @@ pub(crate) async fn save(
))?; ))?;
if timestamp > newest_timestamp { if timestamp > newest_timestamp {
// okay to drop, as we use cached prepared statements
drop(stmt_test);
drop(stmt_insert);
newest_timestamp = timestamp; newest_timestamp = timestamp;
newest_location_id = Some(u32::try_from(conn.last_insert_rowid())?); newest_location_id = Some(u32::try_from(conn.last_insert_rowid())?);
} }

8
src/message.rs
View File

@@ -1613,15 +1613,15 @@ pub async fn delete_msgs(context: &Context, msg_ids: &[MsgId]) -> Result<()> {
modified_chat_ids.insert(msg.chat_id); modified_chat_ids.insert(msg.chat_id);
let target = context.get_delete_msgs_target().await?; let target = context.get_delete_msgs_target().await?;
let update_db = |conn: &mut rusqlite::Connection| { let update_db = |trans: &mut rusqlite::Transaction| {
conn.execute( trans.execute(
"UPDATE imap SET target=? WHERE rfc724_mid=?", "UPDATE imap SET target=? WHERE rfc724_mid=?",
(target, msg.rfc724_mid), (target, msg.rfc724_mid),
)?; )?;
conn.execute("DELETE FROM smtp WHERE msg_id=?", (msg_id,))?; trans.execute("DELETE FROM smtp WHERE msg_id=?", (msg_id,))?;
Ok(()) Ok(())
}; };
if let Err(e) = context.sql.call_write(update_db).await { if let Err(e) = context.sql.transaction(update_db).await {
error!(context, "delete_msgs: failed to update db: {e:#}."); error!(context, "delete_msgs: failed to update db: {e:#}.");
res = Err(e); res = Err(e);
continue; continue;