diff --git a/src/html.rs b/src/html.rs
index d74a5bbac..b4dbd32e7 100644
--- a/src/html.rs
+++ b/src/html.rs
@@ -124,7 +124,7 @@ impl HtmlMsgParser {
async move {
match get_mime_multipart_type(&mail.ctype) {
MimeMultipartType::Multiple => {
- for cur_data in mail.subparts.iter() {
+ for cur_data in &mail.subparts {
self.collect_texts_recursive(cur_data).await?
}
Ok(())
@@ -180,7 +180,7 @@ impl HtmlMsgParser {
async move {
match get_mime_multipart_type(&mail.ctype) {
MimeMultipartType::Multiple => {
- for cur_data in mail.subparts.iter() {
+ for cur_data in &mail.subparts {
self.cid_to_data_recursive(context, cur_data).await?;
}
Ok(())
diff --git a/src/imap.rs b/src/imap.rs
index 2ee391d3e..91f6ae9cc 100644
--- a/src/imap.rs
+++ b/src/imap.rs
@@ -1390,7 +1390,7 @@ impl Imap {
let mut uid_msgs = HashMap::with_capacity(request_uids.len());
let mut count = 0;
- for &request_uid in request_uids.iter() {
+ for &request_uid in &request_uids {
// Check if FETCH response is already in `uid_msgs`.
let mut fetch_response = uid_msgs.remove(&request_uid);
diff --git a/src/lib.rs b/src/lib.rs
index c224ab09d..976d122b4 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -12,7 +12,8 @@
clippy::wildcard_imports,
clippy::needless_borrow,
clippy::cast_lossless,
- clippy::unused_async
+ clippy::unused_async,
+ clippy::explicit_iter_loop
)]
#![allow(
clippy::match_bool,
diff --git a/src/mimefactory.rs b/src/mimefactory.rs
index 0de80907c..6d291ae23 100644
--- a/src/mimefactory.rs
+++ b/src/mimefactory.rs
@@ -485,7 +485,7 @@ impl<'a> MimeFactory<'a> {
None
};
- for (name, addr) in self.recipients.iter() {
+ for (name, addr) in &self.recipients {
if let Some(email_to_remove) = email_to_remove {
if email_to_remove == addr {
continue;
diff --git a/src/mimeparser.rs b/src/mimeparser.rs
index e05e46ad6..000cdac0c 100644
--- a/src/mimeparser.rs
+++ b/src/mimeparser.rs
@@ -640,7 +640,7 @@ impl MimeMessage {
}
if self.is_forwarded {
- for part in self.parts.iter_mut() {
+ for part in &mut self.parts {
part.param.set_int(Param::Forwarded, 1);
}
}
@@ -943,7 +943,7 @@ impl MimeMessage {
}
// Add all parts (we need another part, preferably text/plain, to show as an error message)
- for cur_data in mail.subparts.iter() {
+ for cur_data in &mail.subparts {
if self
.parse_mime_recursive(context, cur_data, is_related)
.await?
@@ -977,7 +977,7 @@ impl MimeMessage {
_ => {
// Add all parts (in fact, AddSinglePartIfKnown() later check if
// the parts are really supported)
- for cur_data in mail.subparts.iter() {
+ for cur_data in &mail.subparts {
if self
.parse_mime_recursive(context, cur_data, is_related)
.await?
diff --git a/src/net.rs b/src/net.rs
index 2d36e90aa..a0f3a3313 100644
--- a/src/net.rs
+++ b/src/net.rs
@@ -57,7 +57,7 @@ async fn lookup_host_with_cache(
}
};
- for addr in resolved_addrs.iter() {
+ for addr in &resolved_addrs {
let ip_string = addr.ip().to_string();
if ip_string == hostname {
// IP address resolved into itself, not interesting to cache.
diff --git a/src/receive_imf.rs b/src/receive_imf.rs
index d30880bf6..f52f0838a 100644
--- a/src/receive_imf.rs
+++ b/src/receive_imf.rs
@@ -604,7 +604,7 @@ async fn add_parts(
// to the sender's name, indicating to the user that he/she is not part of the group.
let from = &mime_parser.from;
let name: &str = from.display_name.as_ref().unwrap_or(&from.addr);
- for part in mime_parser.parts.iter_mut() {
+ for part in &mut mime_parser.parts {
part.param.set(Param::OverrideSenderDisplayname, name);
}
}
@@ -668,7 +668,7 @@ async fn add_parts(
// we use name from From:-header as override name
if prevent_rename {
if let Some(name) = &mime_parser.from.display_name {
- for part in mime_parser.parts.iter_mut() {
+ for part in &mut mime_parser.parts {
part.param.set(Param::OverrideSenderDisplayname, name);
}
}