diff --git a/deltachat-rpc-client/tests/test_something.py b/deltachat-rpc-client/tests/test_something.py index 0449c5beb..3a27e0f84 100644 --- a/deltachat-rpc-client/tests/test_something.py +++ b/deltachat-rpc-client/tests/test_something.py @@ -3,6 +3,7 @@ import concurrent.futures import json import logging import os +import socket import subprocess import time from unittest.mock import MagicMock @@ -70,6 +71,18 @@ def test_configure_starttls(acfactory) -> None: assert account.is_configured() +def test_configure_ip(acfactory) -> None: + account = acfactory.new_preconfigured_account() + + domain = account.get_config("addr").rsplit("@")[-1] + ip_address = socket.gethostbyname(domain) + + # This should fail TLS check. + account.set_config("mail_server", ip_address) + with pytest.raises(JsonRpcError): + account.configure() + + def test_account(acfactory) -> None: alice, bob = acfactory.get_online_accounts(2) diff --git a/src/login_param.rs b/src/login_param.rs index 35c86ec5c..a35f4ee00 100644 --- a/src/login_param.rs +++ b/src/login_param.rs @@ -265,9 +265,7 @@ impl LoginParam { | CertificateChecks::AcceptInvalidCertificates2 => Some(false), }; let provider_strict_tls = self.provider.map(|provider| provider.opt.strict_tls); - user_strict_tls - .or(provider_strict_tls) - .unwrap_or(self.socks5_config.is_some()) + user_strict_tls.or(provider_strict_tls).unwrap_or(true) } }