Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-05-08 09:26:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

refactor: don't use slicing in remove_nonstandard_footer

Browse Source
This commit is contained in:
link2xt
2024-11-18 13:07:01 +00:00
committed by l
parent 06eea7ebe8
commit 9e13486143
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/simplify.rs
View File

@@ -53,7 +53,6 @@ pub(crate) fn remove_message_footer<'a>(
/// Returns `(lines, is_footer_removed)` tuple; /// Returns `(lines, is_footer_removed)` tuple;
/// `is_footer_removed` is set to `true` if the footer was actually removed from `lines` /// `is_footer_removed` is set to `true` if the footer was actually removed from `lines`
/// (which is equal to the input array otherwise). /// (which is equal to the input array otherwise).
#[allow(clippy::indexing_slicing)]
fn remove_nonstandard_footer<'a>(lines: &'a [&str]) -> (&'a [&'a str], bool) { fn remove_nonstandard_footer<'a>(lines: &'a [&str]) -> (&'a [&'a str], bool) {
for (ix, &line) in lines.iter().enumerate() { for (ix, &line) in lines.iter().enumerate() {
if line == "--" if line == "--"
@@ -63,7 +62,10 @@ fn remove_nonstandard_footer<'a>(lines: &'a [&str]) -> (&'a [&'a str], bool) {
|| line.starts_with("*****") || line.starts_with("*****")
|| line.starts_with("~~~~~") || line.starts_with("~~~~~")
{ {
return (&lines[..ix], true); // `get` should always return `Some` here.
if let Some(lines) = lines.get(..ix) {
return (lines, true);
}
} }
} }
(lines, false) (lines, false)