From 9b3e21225caa21c8a7cfb244a27fca62d481d454 Mon Sep 17 00:00:00 2001 From: link2xt Date: Thu, 26 Jan 2023 12:36:22 +0000 Subject: [PATCH] ci: run clippy without actions-rs/clippy-check actions-rs/clippy-check runs clippy with --message-format=json option and converts the output into annotations. This makes clippy output unreadable, it is JSON and you cannot quickly find the line number to fix. Annotations in the code review view look nice, but on large PRs they are less usable because you need to scroll the whole page to find all the annotations. --- .github/workflows/ci.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 71a572ca7..0e75931eb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,10 +31,7 @@ jobs: override: true - name: Cache rust cargo artifacts uses: swatinem/rust-cache@v2 - - uses: actions-rs/clippy-check@v1 - with: - token: ${{ secrets.GITHUB_TOKEN }} - args: --workspace --tests --examples --benches --features repl -- -D warnings + - run: cargo clippy --workspace --tests --examples --benches --features repl -- -D warnings docs: name: Rust doc comments