Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-05-08 01:16:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat: Remove "Download maximum available until" and remove stock string DC_STR_DOWNLOAD_AVAILABILITY (#7369)

Browse Source 
Remove "Download maximum available until", because it's unreliable -
chatmail servers may delete full-messages quicker.

This is part of #7367
This commit is contained in:
Simon Laux
2025-10-29 21:50:58 +01:00
committed by link2xt
parent 95ed31391d
commit 869a6bda68
3 changed files with 0 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
deltachat-ffi/deltachat.h
View File

@@ -7272,13 +7272,6 @@ void dc_event_unref(dc_event_t* event);
/// `%1$s` will be replaced by human-readable size (e.g. "1.2 MiB"). /// `%1$s` will be replaced by human-readable size (e.g. "1.2 MiB").
#define DC_STR_PARTIAL_DOWNLOAD_MSG_BODY 99 #define DC_STR_PARTIAL_DOWNLOAD_MSG_BODY 99
/// "Download maximum available until %1$s"
///
/// Appended after some separator to @ref DC_STR_PARTIAL_DOWNLOAD_MSG_BODY.
///
/// `%1$s` will be replaced by human-readable date and time.
#define DC_STR_DOWNLOAD_AVAILABILITY 100
/// "Multi Device Synchronization" /// "Multi Device Synchronization"
/// ///
/// Used in subjects of outgoing sync messages. /// Used in subjects of outgoing sync messages.

9
src/download.rs
View File

@@ -12,7 +12,6 @@ use crate::context::Context;
use crate::imap::session::Session; use crate::imap::session::Session;
use crate::message::{Message, MsgId, Viewtype}; use crate::message::{Message, MsgId, Viewtype};
use crate::mimeparser::{MimeMessage, Part}; use crate::mimeparser::{MimeMessage, Part};
use crate::tools::time;
use crate::{EventType, chatlist_events, stock_str}; use crate::{EventType, chatlist_events, stock_str};
/// Download limits should not be used below `MIN_DOWNLOAD_LIMIT`. /// Download limits should not be used below `MIN_DOWNLOAD_LIMIT`.
@@ -230,14 +229,6 @@ impl MimeMessage {
"[{}]", "[{}]",
stock_str::partial_download_msg_body(context, org_bytes).await stock_str::partial_download_msg_body(context, org_bytes).await
); );
if let Some(delete_server_after) = context.get_config_delete_server_after().await? {
let until = stock_str::download_availability(
context,
time() + max(delete_server_after, MIN_DELETE_SERVER_AFTER),
)
.await;
text += format!(" [{until}]").as_str();
};
info!(context, "Partial download: {}", text); info!(context, "Partial download: {}", text);

11
src/stock_str.rs
View File

@@ -17,7 +17,6 @@ use crate::contact::{Contact, ContactId};
use crate::context::Context; use crate::context::Context;
use crate::message::{Message, Viewtype}; use crate::message::{Message, Viewtype};
use crate::param::Param; use crate::param::Param;
use crate::tools::timestamp_to_str;
/// Storage for string translations. /// Storage for string translations.
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
@@ -170,9 +169,6 @@ pub enum StockMessage {
#[strum(props(fallback = "%1$s message"))] #[strum(props(fallback = "%1$s message"))]
PartialDownloadMsgBody = 99, PartialDownloadMsgBody = 99,
#[strum(props(fallback = "Download maximum available until %1$s"))]
DownloadAvailability = 100,
#[strum(props(fallback = "Multi Device Synchronization"))] #[strum(props(fallback = "Multi Device Synchronization"))]
SyncMsgSubject = 101, SyncMsgSubject = 101,
@@ -1127,13 +1123,6 @@ pub(crate) async fn partial_download_msg_body(context: &Context, org_bytes: u32)
.replace1(size) .replace1(size)
} }
/// Stock string: `Download maximum available until %1$s`.
pub(crate) async fn download_availability(context: &Context, timestamp: i64) -> String {
translated(context, StockMessage::DownloadAvailability)
.await
.replace1(&timestamp_to_str(timestamp))
}
/// Stock string: `Incoming Messages`. /// Stock string: `Incoming Messages`.
pub(crate) async fn incoming_messages(context: &Context) -> String { pub(crate) async fn incoming_messages(context: &Context) -> String {
translated(context, StockMessage::IncomingMessages).await translated(context, StockMessage::IncomingMessages).await