From 81418d8ee55630984cb2ae6ceec5e504e1c5fc33 Mon Sep 17 00:00:00 2001 From: link2xt Date: Sun, 19 Mar 2023 10:13:59 +0000 Subject: [PATCH] Log error on pause guard drop without resuming instead of working around I checked that tests still pass even if error! is replaced with panic! --- src/scheduler.rs | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/scheduler.rs b/src/scheduler.rs index 9c9600d3a..e1638fd09 100644 --- a/src/scheduler.rs +++ b/src/scheduler.rs @@ -219,14 +219,9 @@ impl<'a> Drop for IoPausedGuard<'a> { if self.done { return; } - let context = self.context.clone(); - tokio::spawn(async move { - let mut inner = context.scheduler.inner.write().await; - inner.paused = false; - if inner.started && inner.scheduler.is_none() { - SchedulerState::do_start(inner, context.clone()).await; - } - }); + + // Async .resume() should be called manually due to lack of async drop. + error!(self.context, "Pause guard dropped without resuming."); } }