remove falsy comment

This commit is contained in:
Sebastian Klähn
2022-09-14 15:21:01 +02:00
committed by Septias
parent 35f22d6c23
commit 81415ce20e

View File

@@ -421,11 +421,8 @@ impl Context {
} }
/// Attempts to send queued webxdc status updates. /// Attempts to send queued webxdc status updates.
/// pub(crate) async fn flush_status_updates(&self) -> Result<()> {
/// Returns true if there are more status updates to send, but rate limiter does not let update_needed = get_busy_webxdc_instances(&self).await?;
/// allow to send them. Returns false if there are no more status updates to send.
pub(crate) async fn flush_status_updates(&self) -> Result<bool> {
let update_needed = get_busy_webxdc_instances(&self.sql).await?;
while let Some((instance_id, first_serial, last_serial, descr)) = while let Some((instance_id, first_serial, last_serial, descr)) =
self.pop_smtp_status_update().await? self.pop_smtp_status_update().await?
@@ -451,11 +448,11 @@ impl Context {
chat::send_msg(self, instance.chat_id, &mut status_update).await?; chat::send_msg(self, instance.chat_id, &mut status_update).await?;
} }
} }
let update_needed_after_sending = get_busy_webxdc_instances(&self.sql).await?; let update_needed_after_sending = get_busy_webxdc_instances(&self).await?;
for msg_id in update_needed.difference(&update_needed_after_sending) { for msg_id in update_needed.difference(&update_needed_after_sending) {
self.emit_event(EventType::WebxdcUpToDate { msg_id: *msg_id }) self.emit_event(EventType::WebxdcUpToDate { msg_id: *msg_id })
} }
Ok(false) Ok(())
} }
pub(crate) fn build_status_update_part(&self, json: &str) -> PartBuilder { pub(crate) fn build_status_update_part(&self, json: &str) -> PartBuilder {
@@ -755,8 +752,9 @@ impl Message {
} }
/// Returns a hashset of all webxdc instaces which still have updates to send /// Returns a hashset of all webxdc instaces which still have updates to send
pub(crate) async fn get_busy_webxdc_instances(sql: &Sql) -> Result<HashSet<MsgId>> { pub async fn get_busy_webxdc_instances(ctx: &Context) -> Result<HashSet<MsgId>> {
Ok(sql Ok(ctx
.sql
.distinct("smtp_status_updates", "msg_id") .distinct("smtp_status_updates", "msg_id")
.await? .await?
.into_iter() .into_iter()