From 5ebca15502208c9d35759485efdae5991e54c5db Mon Sep 17 00:00:00 2001 From: link2xt Date: Mon, 18 Nov 2024 20:03:39 +0000 Subject: [PATCH] refactor: get rid of slicing in `remove_top_quote` --- src/simplify.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/simplify.rs b/src/simplify.rs index 59fc8dfa7..6e589a5fc 100644 --- a/src/simplify.rs +++ b/src/simplify.rs @@ -218,7 +218,6 @@ fn remove_bottom_quote<'a>(lines: &'a [&str]) -> (&'a [&'a str], Option) } } -#[allow(clippy::indexing_slicing)] fn remove_top_quote<'a>( lines: &'a [&str], is_chat_message: bool, @@ -245,10 +244,12 @@ fn remove_top_quote<'a>( } if let Some(last_quoted_line) = last_quoted_line { ( - &lines[last_quoted_line + 1..], + lines.get(last_quoted_line + 1..).unwrap_or(lines), Some( - lines[first_quoted_line..last_quoted_line + 1] + lines .iter() + .take(last_quoted_line + 1) + .skip(first_quoted_line) .map(|s| { s.strip_prefix('>') .map_or(*s, |u| u.strip_prefix(' ').unwrap_or(u))