From 5d90cc7a2a7b4208f661eaa522417d5eabacde2f Mon Sep 17 00:00:00 2001 From: link2xt Date: Wed, 25 Mar 2026 02:09:28 +0100 Subject: [PATCH] test: remove test_old_message_5 It is not clear now what this is testing. Golden test shows messages ordered incorrectly according to the timestamps, they should be ordered the other way round. Comment talks about fetching from mvbox and inbox in paralell which is a rare case that could have happened if one message is left in the inbox and the other message is a chat message moved to mvbox. We never download anything that is not moved to the target folder. The test also resides in "verified chats" tests which are all legacy tests we kept after replacing the concept of verified/protected chats with key contacts in 2.x. --- src/tests/verified_chats.rs | 40 ----------------------------- test-data/golden/test_old_message_5 | 5 ---- 2 files changed, 45 deletions(-) delete mode 100644 test-data/golden/test_old_message_5 diff --git a/src/tests/verified_chats.rs b/src/tests/verified_chats.rs index 0c211c2af..427cc3088 100644 --- a/src/tests/verified_chats.rs +++ b/src/tests/verified_chats.rs @@ -246,46 +246,6 @@ async fn test_old_message_4() -> Result<()> { Ok(()) } -/// Alice is offline for some time. -/// When they come online, first their mvbox is synced and then their inbox. -/// This test tests that the messages are still in the right order. -#[tokio::test(flavor = "multi_thread", worker_threads = 2)] -async fn test_old_message_5() -> Result<()> { - let alice = TestContext::new_alice().await; - let msg_sent = receive_imf( - &alice, - b"From: alice@example.org\n\ - To: Bob \n\ - Message-ID: <1234-2-4@example.org>\n\ - Date: Sat, 07 Dec 2019 19:00:27 +0000\n\ - \n\ - Happy birthday, Bob!\n", - true, - ) - .await? - .unwrap(); - - let msg_incoming = receive_imf( - &alice, - b"From: Bob \n\ - To: alice@example.org\n\ - Message-ID: <1234-2-3@example.org>\n\ - Date: Sun, 07 Dec 2019 19:00:26 +0000\n\ - \n\ - Happy birthday to me, Alice!\n", - false, - ) - .await? - .unwrap(); - - assert!(msg_sent.sort_timestamp == msg_incoming.sort_timestamp); - alice - .golden_test_chat(msg_sent.chat_id, "test_old_message_5") - .await; - - Ok(()) -} - #[tokio::test(flavor = "multi_thread", worker_threads = 2)] async fn test_mdn_doesnt_disable_verification() -> Result<()> { let mut tcm = TestContextManager::new(); diff --git a/test-data/golden/test_old_message_5 b/test-data/golden/test_old_message_5 deleted file mode 100644 index 92bd8ac86..000000000 --- a/test-data/golden/test_old_message_5 +++ /dev/null @@ -1,5 +0,0 @@ -Single#Chat#11001: Bob [bob@example.net] Icon: 4138c52e5bc1c576cda7dd44d088c07.png --------------------------------------------------------------------------------- -Msg#11001: Me (Contact#Contact#Self): Happy birthday, Bob! √ -Msg#11002: (Contact#Contact#11001): Happy birthday to me, Alice! [FRESH] ---------------------------------------------------------------------------------