From 5a71fe101e4713540f08b46706dd9b683923b2f3 Mon Sep 17 00:00:00 2001 From: link2xt Date: Wed, 16 Sep 2026 01:37:43 +0000 Subject: [PATCH] test: do not talk about "inconsistent key state" in test_securejoin_after_contact_resetup "Inconsistent key state" referred to acpeerstates table row with different Autocrypt and verified keys. Since v2 and introduction of key contacts it is not possible for a contact to have inconsistent key state, so this translates to having two contacts with the same email address but different keys. --- deltachat-rpc-client/tests/test_securejoin.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/deltachat-rpc-client/tests/test_securejoin.py b/deltachat-rpc-client/tests/test_securejoin.py index 47d79d8e5..15664c734 100644 --- a/deltachat-rpc-client/tests/test_securejoin.py +++ b/deltachat-rpc-client/tests/test_securejoin.py @@ -525,8 +525,8 @@ def test_aeap_flow(acf): def test_securejoin_after_contact_resetup(acf) -> None: """ Regression test for a bug that prevented joining a group with a QR code - if the group already contains a contact with an inconsistent key state - while a securejoin with that contact is still pending. + if the group already contains a contact with the same address as the inviter, + but different key fingerprint while a securejoin with that contact is still pending. """ ac1, ac2, ac3 = acf.get_online_accounts(3) @@ -557,8 +557,8 @@ def test_securejoin_after_contact_resetup(acf) -> None: # ac1 goes offline. ac1.remove() - # Scanning a QR code creates a group with the inviter, here ac1, - # which has an inconsistent key state. Normally the securejoin protocol + # Scanning a QR code creates a group with the inviter, here ac1. + # Normally the securejoin protocol # would complete and "Member added" would arrive, # but ac1 is offline so it never finishes. logging.info("ac2 scans ac1 QR code, this is not expected to finish")