From 598ac45eeca9467c8062e2392db4a2da609bebc0 Mon Sep 17 00:00:00 2001 From: link2xt Date: Tue, 30 Jun 2026 15:51:11 +0000 Subject: [PATCH] fixup: simplify should_compress calculation --- src/mimefactory.rs | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/mimefactory.rs b/src/mimefactory.rs index fa4bebe02..47b36909f 100644 --- a/src/mimefactory.rs +++ b/src/mimefactory.rs @@ -1347,13 +1347,15 @@ impl MimeFactory { subject: subject_str, }; + let is_securejoin_message = match &self.loaded { + Loaded::Message { msg, .. } => msg.param.get_cmd() == SystemMessage::SecurejoinMessage, + Loaded::Mdn { .. } => false, + }; + // Disable compression for SecureJoin to ensure // there are no compression side channels // leaking information about the tokens. - let should_compress = match &self.loaded { - Loaded::Message { msg, .. } => msg.param.get_cmd() != SystemMessage::SecurejoinMessage, - Loaded::Mdn { .. } => true, - }; + let should_compress = !is_securejoin_message; let shared_secret: Option = match &self.loaded { Loaded::Message { chat, msg } if should_encrypt_with_broadcast_secret(msg, chat) => { @@ -1464,11 +1466,6 @@ impl MimeFactory { } let is_encrypted = self.will_be_encrypted(); - let is_securejoin_message = if let Loaded::Message { msg, .. } = &self.loaded { - msg.param.get_cmd() == SystemMessage::SecurejoinMessage - } else { - false - }; let display_name = if is_securejoin_message && !is_encrypted { // Unencrypted securejoin messages should _not_ include the display name.