Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-04-29 03:16:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

dc_receive_imf: replace chat_id.is_error() with chat_id.is_unset()

Browse Source 
Both methods do the same: compare chat_id to 0. However, in these cases
0 refers to the state when chat_id is not determined yet, because no
corresponding chat has been found.

All functions that returned 0 to indicate error have already been
resultified.
This commit is contained in:
Alexander Krotov
2020-06-06 18:29:29 +03:00
parent cd751a64cb
commit 5239f2edad
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/dc_receive_imf.rs
View File

@@ -1001,7 +1001,7 @@ async fn create_or_lookup_group(
let (mut chat_id, chat_id_verified, _blocked) = chat::get_chat_id_by_grpid(context, &grpid) let (mut chat_id, chat_id_verified, _blocked) = chat::get_chat_id_by_grpid(context, &grpid)
.await .await
.unwrap_or((ChatId::new(0), false, Blocked::Not)); .unwrap_or((ChatId::new(0), false, Blocked::Not));
if !chat_id.is_error() { if !chat_id.is_unset() {
if chat_id_verified { if chat_id_verified {
if let Err(err) = if let Err(err) =
check_verified_properties(context, mime_parser, from_id as u32, to_ids).await check_verified_properties(context, mime_parser, from_id as u32, to_ids).await
@@ -1032,7 +1032,7 @@ async fn create_or_lookup_group(
.await .await
.unwrap_or_default(); .unwrap_or_default();
if chat_id.is_error() if chat_id.is_unset()
&& !mime_parser.is_mailinglist_message() && !mime_parser.is_mailinglist_message()
&& !grpid.is_empty() && !grpid.is_empty()
&& grpname.is_some() && grpname.is_some()