Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-05-20 23:36:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1354 from deltachat/fix-bcc-self-group-crash

Browse Source 
fix crash in self-only-groups with bcc_self enabled
This commit is contained in:
bjoern
2020-03-23 12:21:27 +01:00
committed by GitHub
parent 70e0d3b571 17ff1ab372
commit 4fabddeb47
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
python/tests/test_account.py
View File

@@ -76,6 +76,20 @@ class TestOfflineAccountBasic:
with pytest.raises(KeyError): with pytest.raises(KeyError):
ac1.get_config("123123") ac1.get_config("123123")
def test_empty_group_bcc_self_enabled(self, acfactory):
ac1 = acfactory.get_configured_offline_account()
ac1.set_config("bcc_self", "1")
chat = ac1.create_group_chat(name="group1")
msg = chat.send_text("msg1")
assert msg in chat.get_messages()
def test_empty_group_bcc_self_disabled(self, acfactory):
ac1 = acfactory.get_configured_offline_account()
ac1.set_config("bcc_self", "0")
chat = ac1.create_group_chat(name="group1")
msg = chat.send_text("msg1")
assert msg in chat.get_messages()
class TestOfflineContact: class TestOfflineContact:
def test_contact_attr(self, acfactory): def test_contact_attr(self, acfactory):

6
src/mimefactory.rs
View File

@@ -368,7 +368,7 @@ impl<'a, 'b> MimeFactory<'a, 'b> {
self.from_addr.clone(), self.from_addr.clone(),
); );
let mut to = Vec::with_capacity(self.recipients.len()); let mut to = Vec::new();
for (name, addr) in self.recipients.iter() { for (name, addr) in self.recipients.iter() {
if name.is_empty() { if name.is_empty() {
to.push(Address::new_mailbox(addr.clone())); to.push(Address::new_mailbox(addr.clone()));
@@ -380,6 +380,10 @@ impl<'a, 'b> MimeFactory<'a, 'b> {
} }
} }
if to.is_empty() {
to.push(from.clone());
}
if !self.references.is_empty() { if !self.references.is_empty() {
unprotected_headers.push(Header::new("References".into(), self.references.clone())); unprotected_headers.push(Header::new("References".into(), self.references.clone()));
} }