test: replace create_chat() with get_chat() in test_setup_contact_ex() and test_secure_join()

We do not want to create the chat,
but only check some properties of it even when it is hidden.
Creating a chat makes it appear in the chatlist.
This commit is contained in:
link2xt
2025-03-04 22:00:30 +00:00
parent b699ac1aca
commit 476224b980

View File

@@ -141,7 +141,7 @@ async fn test_setup_contact_ex(case: SetupContactCase) {
msg.get_header(HeaderDef::SecureJoin).unwrap(), msg.get_header(HeaderDef::SecureJoin).unwrap(),
"vc-auth-required" "vc-auth-required"
); );
let bob_chat = bob.create_chat(&alice).await; let bob_chat = bob.get_chat(&alice).await;
assert_eq!(bob_chat.can_send(&bob).await.unwrap(), false); assert_eq!(bob_chat.can_send(&bob).await.unwrap(), false);
assert_eq!( assert_eq!(
bob_chat.why_cant_send(&bob).await.unwrap(), bob_chat.why_cant_send(&bob).await.unwrap(),
@@ -154,7 +154,7 @@ async fn test_setup_contact_ex(case: SetupContactCase) {
// Step 4: Bob receives vc-auth-required, sends vc-request-with-auth // Step 4: Bob receives vc-auth-required, sends vc-request-with-auth
bob.recv_msg_trash(&sent).await; bob.recv_msg_trash(&sent).await;
let bob_chat = bob.create_chat(&alice).await; let bob_chat = bob.get_chat(&alice).await;
assert_eq!(bob_chat.can_send(&bob).await.unwrap(), true); assert_eq!(bob_chat.can_send(&bob).await.unwrap(), true);
// Check Bob emitted the JoinerProgress event. // Check Bob emitted the JoinerProgress event.
@@ -252,7 +252,7 @@ async fn test_setup_contact_ex(case: SetupContactCase) {
assert_eq!(contact_bob.is_bot(), false); assert_eq!(contact_bob.is_bot(), false);
// exactly one one-to-one chat should be visible for both now // exactly one one-to-one chat should be visible for both now
// (check this before calling alice.create_chat() explicitly below) // (check this before calling alice.get_chat() explicitly below)
assert_eq!( assert_eq!(
Chatlist::try_load(&alice, 0, None, None) Chatlist::try_load(&alice, 0, None, None)
.await .await
@@ -267,7 +267,7 @@ async fn test_setup_contact_ex(case: SetupContactCase) {
// Check Alice got the verified message in her 1:1 chat. // Check Alice got the verified message in her 1:1 chat.
{ {
let chat = alice.create_chat(&bob).await; let chat = alice.get_chat(&bob).await;
let msg = get_chat_msg(&alice, chat.get_id(), 0, 1).await; let msg = get_chat_msg(&alice, chat.get_id(), 0, 1).await;
assert!(msg.is_info()); assert!(msg.is_info());
let expected_text = chat_protection_enabled(&alice).await; let expected_text = chat_protection_enabled(&alice).await;
@@ -669,11 +669,11 @@ async fn test_secure_join() -> Result<()> {
assert_eq!(Chatlist::try_load(&bob, 0, None, None).await?.len(), 1); assert_eq!(Chatlist::try_load(&bob, 0, None, None).await?.len(), 1);
// If Bob then sends a direct message to alice, however, the one-to-one with Alice should appear. // If Bob then sends a direct message to alice, however, the one-to-one with Alice should appear.
let bobs_chat_with_alice = bob.create_chat(&alice).await; let bobs_chat_with_alice = bob.get_chat(&alice).await;
let sent = bob.send_text(bobs_chat_with_alice.id, "Hello").await; let sent = bob.send_text(bobs_chat_with_alice.id, "Hello").await;
alice.recv_msg(&sent).await; alice.recv_msg(&sent).await;
assert_eq!(Chatlist::try_load(&alice, 0, None, None).await?.len(), 2); assert_eq!(Chatlist::try_load(&alice, 0, None, None).await?.len(), 2);
assert_eq!(Chatlist::try_load(&bob, 0, None, None).await?.len(), 2); assert_eq!(Chatlist::try_load(&bob, 0, None, None).await?.len(), 1);
Ok(()) Ok(())
} }