Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-09-22 04:58:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

test(direct_imap): always pass mark_seen=False to fetch()

Browse Source 
mark_seen=True is the default and translates to fetching BODY
of the message. mark_seen=False translates to fetching BODY.PEEK
that is described in IETF RFC 3501 as
"An alternate form of BODY[<section>] that does not implicitly set the \Seen flag."

It is unexpected unless you know this detail of IMAP protocol already,
but this is not going to be fixed in imap_tools: <https://github.com/ikvk/imap_tools/issues/179>
This commit is contained in:
link2xt
2026-09-13 21:39:11 +00:00
committed by l
parent 555b8b8b51
commit 44c2febbe1
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
deltachat-rpc-client/tests/conftest.py
View File

@@ -171,7 +171,7 @@ class DirectImap:
self.conn.append(bytes(msg, encoding="ascii"), folder) self.conn.append(bytes(msg, encoding="ascii"), folder)
def get_uid_by_message_id(self, message_id) -> str: def get_uid_by_message_id(self, message_id) -> str:
msgs = [msg.uid for msg in self.conn.fetch(AND(header=Header("MESSAGE-ID", message_id)))] msgs = [msg.uid for msg in self.conn.fetch(AND(header=Header("MESSAGE-ID", message_id)), mark_seen=False)]
if len(msgs) == 0: if len(msgs) == 0:
raise Exception("Did not find message " + message_id + ", maybe you forgot to select the correct folder?") raise Exception("Did not find message " + message_id + ", maybe you forgot to select the correct folder?")
return msgs[0] return msgs[0]

6
python/src/deltachat/direct_imap.py
View File

@@ -104,11 +104,11 @@ class DirectImap:
def get_all_messages(self) -> List[MailMessage]: def get_all_messages(self) -> List[MailMessage]:
assert not self._idling assert not self._idling
return list(self.conn.fetch()) return list(self.conn.fetch(mark_seen=False))
def get_unread_messages(self) -> List[str]: def get_unread_messages(self) -> List[str]:
assert not self._idling assert not self._idling
return [msg.uid for msg in self.conn.fetch(AND(seen=False))] return [msg.uid for msg in self.conn.fetch(AND(seen=False), mark_seen=False)]
def mark_all_read(self): def mark_all_read(self):
messages = self.get_unread_messages() messages = self.get_unread_messages()
@@ -183,7 +183,7 @@ class DirectImap:
self.conn.append(bytes(msg, encoding="ascii"), folder) self.conn.append(bytes(msg, encoding="ascii"), folder)
def get_uid_by_message_id(self, message_id) -> str: def get_uid_by_message_id(self, message_id) -> str:
msgs = [msg.uid for msg in self.conn.fetch(AND(header=Header("MESSAGE-ID", message_id)))] msgs = [msg.uid for msg in self.conn.fetch(AND(header=Header("MESSAGE-ID", message_id)), mark_seen=False)]
if len(msgs) == 0: if len(msgs) == 0:
raise Exception("Did not find message " + message_id + ", maybe you forgot to select the correct folder?") raise Exception("Did not find message " + message_id + ", maybe you forgot to select the correct folder?")
return msgs[0] return msgs[0]