Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-05-13 20:06:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow creation of groups by outgoing messages without recipients

Browse Source 
`!to_ids().is_empty()` check is needed in cases of 1:1 chat creation
because otherwise `to_id` is undefined,
but in case of outgoing group message without recipients
observed on a second device creating a group should be allowed.
This commit is contained in:
link2xt
2024-05-30 13:28:28 +00:00
parent b7e5b906d1
commit 42a7cd3eea
2 changed files with 36 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/receive_imf.rs
View File

@@ -1098,23 +1098,24 @@ async fn add_parts(
} }
} }
if !to_ids.is_empty() { if chat_id.is_none() && allow_creation {
if chat_id.is_none() && allow_creation { if let Some((new_chat_id, new_chat_id_blocked)) = create_group(
if let Some((new_chat_id, new_chat_id_blocked)) = create_group( context,
context, mime_parser,
mime_parser, is_partial_download.is_some(),
is_partial_download.is_some(), Blocked::Not,
Blocked::Not, from_id,
from_id, to_ids,
to_ids, &verified_encryption,
&verified_encryption, )
) .await?
.await? {
{ chat_id = Some(new_chat_id);
chat_id = Some(new_chat_id); chat_id_blocked = new_chat_id_blocked;
chat_id_blocked = new_chat_id_blocked;
}
} }
}
if !to_ids.is_empty() {
if chat_id.is_none() && allow_creation { if chat_id.is_none() && allow_creation {
let to_contact = Contact::get_by_id(context, to_id).await?; let to_contact = Contact::get_by_id(context, to_id).await?;
if let Some(list_id) = to_contact.param.get(Param::ListId) { if let Some(list_id) = to_contact.param.get(Param::ListId) {

19
src/receive_imf/tests.rs
View File

@@ -4593,3 +4593,22 @@ async fn test_receive_vcard() -> Result<()> {
Ok(()) Ok(())
} }
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn test_group_no_recipients() -> Result<()> {
let t = &TestContext::new_alice().await;
let raw = b"From: alice@example.org\n\
Subject: Group\n\
Chat-Version: 1.0\n\
Chat-Group-Name: Group\n\
Chat-Group-ID: GePFDkwEj2K\n\
Message-ID: <foobar@localhost>\n\
\n\
Hello!";
let received = receive_imf(t, raw, false).await?.unwrap();
let msg = Message::load_from_db(t, *received.msg_ids.last().unwrap()).await?;
let chat = Chat::load_from_db(t, msg.chat_id).await?;
assert_eq!(chat.typ, Chattype::Group);
Ok(())
}