refactor: remove Aheader::new

This commit is contained in:
link2xt
2025-09-02 19:15:48 +00:00
committed by l
parent bed1623dcb
commit 4033566b4a
3 changed files with 25 additions and 38 deletions

View File

@@ -48,21 +48,6 @@ pub struct Aheader {
pub prefer_encrypt: EncryptPreference, pub prefer_encrypt: EncryptPreference,
} }
impl Aheader {
/// Creates new autocrypt header
pub fn new(
addr: String,
public_key: SignedPublicKey,
prefer_encrypt: EncryptPreference,
) -> Self {
Aheader {
addr,
public_key,
prefer_encrypt,
}
}
}
impl fmt::Display for Aheader { impl fmt::Display for Aheader {
fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result { fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
write!(fmt, "addr={};", self.addr.to_lowercase())?; write!(fmt, "addr={};", self.addr.to_lowercase())?;
@@ -243,11 +228,11 @@ mod tests {
assert!( assert!(
format!( format!(
"{}", "{}",
Aheader::new( Aheader {
"test@example.com".to_string(), addr: "test@example.com".to_string(),
SignedPublicKey::from_base64(RAWKEY).unwrap(), public_key: SignedPublicKey::from_base64(RAWKEY).unwrap(),
EncryptPreference::Mutual prefer_encrypt: EncryptPreference::Mutual
) }
) )
.contains("prefer-encrypt=mutual;") .contains("prefer-encrypt=mutual;")
); );
@@ -258,11 +243,11 @@ mod tests {
assert!( assert!(
!format!( !format!(
"{}", "{}",
Aheader::new( Aheader {
"test@example.com".to_string(), addr: "test@example.com".to_string(),
SignedPublicKey::from_base64(RAWKEY).unwrap(), public_key: SignedPublicKey::from_base64(RAWKEY).unwrap(),
EncryptPreference::NoPreference prefer_encrypt: EncryptPreference::NoPreference
) }
) )
.contains("prefer-encrypt") .contains("prefer-encrypt")
); );
@@ -271,11 +256,11 @@ mod tests {
assert!( assert!(
format!( format!(
"{}", "{}",
Aheader::new( Aheader {
"TeSt@eXaMpLe.cOm".to_string(), addr: "TeSt@eXaMpLe.cOm".to_string(),
SignedPublicKey::from_base64(RAWKEY).unwrap(), public_key: SignedPublicKey::from_base64(RAWKEY).unwrap(),
EncryptPreference::Mutual prefer_encrypt: EncryptPreference::Mutual
) }
) )
.contains("test@example.com") .contains("test@example.com")
); );

View File

@@ -31,9 +31,11 @@ impl EncryptHelper {
} }
pub fn get_aheader(&self) -> Aheader { pub fn get_aheader(&self) -> Aheader {
let pk = self.public_key.clone(); Aheader {
let addr = self.addr.to_string(); addr: self.addr.clone(),
Aheader::new(addr, pk, self.prefer_encrypt) public_key: self.public_key.clone(),
prefer_encrypt: self.prefer_encrypt,
}
} }
/// Tries to encrypt the passed in `mail`. /// Tries to encrypt the passed in `mail`.

View File

@@ -1092,13 +1092,13 @@ impl MimeFactory {
continue; continue;
} }
let header = Aheader::new( let header = Aheader {
addr.clone(), addr: addr.clone(),
key.clone(), public_key: key.clone(),
// Autocrypt 1.1.0 specification says that // Autocrypt 1.1.0 specification says that
// `prefer-encrypt` attribute SHOULD NOT be included. // `prefer-encrypt` attribute SHOULD NOT be included.
EncryptPreference::NoPreference, prefer_encrypt: EncryptPreference::NoPreference,
) }
.to_string(); .to_string();
message = message.header( message = message.header(