unify deps and more strict start and stop

Cargo.toml

@@ -20,12 +20,12 @@ smallvec = "1.0.0"
 reqwest = { version = "0.10.0", features = ["blocking", "json"] }
 num-derive = "0.3.0"
 num-traits = "0.2.6"
-async-smtp = "0.3"
+async-smtp = { git = "https://github.com/async-email/async-smtp", version = "0.3" }
 email = { git = "https://github.com/deltachat/rust-email", branch = "master" }
 lettre_email = { git = "https://github.com/deltachat/lettre", branch = "master" }
-async-imap = { git = "https://github.com/async-email/async-imap", branch = "feat/send" }
-async-native-tls = "0.3.1"
-async-std = { git = "https://github.com/async-rs/async-std", features = ["unstable"] }
+async-imap = { git = "https://github.com/async-email/async-imap" }
+async-native-tls = { git = "https://github.com/async-email/async-native-tls", version = "0.3.1" }
+async-std = { version = "1.6.0-beta.2", features = ["unstable"] }
 base64 = "0.11"
 charset = "0.1"
 percent-encoding = "2.0"
@@ -50,7 +50,7 @@ escaper = "0.1.0"
 bitflags = "1.1.0"
 debug_stub_derive = "0.3.0"
 sanitize-filename = "0.2.1"
-stop-token = { version = "0.1.1", features = ["unstable"] }
+stop-token = { git = "https://github.com/dignifiedquire/stop-token", version = "0.1.1", features = ["unstable"] }
 mailparse = "0.12.0"
 encoded-words = { git = "https://github.com/async-email/encoded-words", branch="master" }
 native-tls = "0.2.3"
@@ -71,7 +71,7 @@ tempfile = "3.0"
 pretty_assertions = "0.6.1"
 pretty_env_logger = "0.3.0"
 proptest = "0.9.4"
-async-std = { git = "https://github.com/async-rs/async-std", features = ["unstable", "attributes"] }
+async-std = { version = "1.6.0-beta.2", features = ["unstable", "attributes"] }
 
 [workspace]
 members = [

deltachat-ffi/Cargo.toml

@@ -20,7 +20,7 @@ libc = "0.2"
 human-panic = "1.0.1"
 num-traits = "0.2.6"
 serde_json = "1.0"
-async-std = { git = "https://github.com/async-rs/async-std" }
+async-std = "1.6.0-beta.2"
 anyhow = "1.0.28"
 thiserror = "1.0.14"
 
@@ -28,3 +28,4 @@ thiserror = "1.0.14"
 default = ["vendored", "nightly"]
 vendored = ["deltachat/vendored"]
 nightly = ["deltachat/nightly"]
+

deltachat-ffi/src/lib.rs

@@ -1875,7 +1875,6 @@ pub unsafe extern "C" fn dc_imex(
         }
     };
 
-    // TODO: this is now blocking, figure out if that is okay
     let ffi_context = &*context;
 
     let param1 = to_opt_string_lossy(param1);

python/src/deltachat/account.py

@@ -587,6 +587,9 @@ class Account(object):
 
     def stop_scheduler(self):
         """ stop core scheduler if it is running. """
+        self.ac_log_line("stop_ongoing")
+        self.stop_ongoing()
+        
         self.ac_log_line("context_shutdown (stop core scheduler)")
         self.stop_ongoing()
         lib.dc_context_shutdown(self._dc_context)

src/context.rs

@@ -138,12 +138,10 @@ impl Context {
     }
 
     pub async fn run(&self) {
-        if self.is_running().await {
-            return;
-        }
+        assert!(!self.is_running().await, "context is already running");
 
         let l = &mut *self.inner.scheduler.write().await;
-        l.run(self.clone());
+        l.run(self.clone()).await;
     }
 
     pub async fn is_running(&self) -> bool {
@@ -153,6 +151,7 @@ impl Context {
     pub async fn stop(&self) {
         info!(self, "stopping context");
         self.inner.stop().await;
+        info!(self, "stopped context");
     }
 
     /// Returns a reference to the underlying SQL instance.
@@ -499,7 +498,7 @@ impl InnerContext {
     }
 
     async fn stop(&self) {
-        if self.is_running().await {
+        assert!(self.is_running().await, "context is already stopped");
         let token = {
             let lock = &*self.scheduler.read().await;
             lock.pre_stop().await
@@ -509,7 +508,6 @@ impl InnerContext {
             lock.stop(token).await;
         }
     }
-    }
 }
 
 impl Default for RunningState {

src/scheduler.rs

@@ -17,9 +17,13 @@ pub(crate) enum Scheduler {
     Stopped,
     Running {
         inbox: ImapConnectionState,
+        inbox_handle: Option<task::JoinHandle<()>>,
         mvbox: ImapConnectionState,
+        mvbox_handle: Option<task::JoinHandle<()>>,
         sentbox: ImapConnectionState,
+        sentbox_handle: Option<task::JoinHandle<()>>,
         smtp: SmtpConnectionState,
+        smtp_handle: Option<task::JoinHandle<()>>,
         probe_network: bool,
     },
 }
@@ -47,7 +51,7 @@ impl Context {
     }
 }
 
-async fn inbox_loop(ctx: Context, inbox_handlers: ImapConnectionHandlers) {
+async fn inbox_loop(ctx: Context, started: Sender<()>, inbox_handlers: ImapConnectionHandlers) {
     use futures::future::FutureExt;
 
     info!(ctx, "starting inbox loop");
@@ -59,6 +63,7 @@ async fn inbox_loop(ctx: Context, inbox_handlers: ImapConnectionHandlers) {
 
     let ctx1 = ctx.clone();
     let fut = async move {
+        started.send(()).await;
         let ctx = ctx1;
         if let Err(err) = connection.connect_configured(&ctx).await {
             error!(ctx, "{}", err);
@@ -92,8 +97,13 @@ async fn inbox_loop(ctx: Context, inbox_handlers: ImapConnectionHandlers) {
         }
     };
 
-    info!(ctx, "Shutting down inbox loop");
-    fut.race(stop_receiver.recv().map(|_| ())).await;
+    stop_receiver
+        .recv()
+        .map(|_| {
+            info!(ctx, "shutting down inbox loop");
+        })
+        .race(fut)
+        .await;
     shutdown_sender.send(()).await;
 }
 
@@ -147,6 +157,7 @@ async fn fetch_idle(ctx: &Context, connection: &mut Imap) {
 
 async fn simple_imap_loop(
     ctx: Context,
+    started: Sender<()>,
     inbox_handlers: ImapConnectionHandlers,
     folder: impl AsRef<str>,
 ) {
@@ -159,7 +170,11 @@ async fn simple_imap_loop(
         shutdown_sender,
     } = inbox_handlers;
 
+    let ctx1 = ctx.clone();
+
     let fut = async move {
+        started.send(()).await;
+        let ctx = ctx1;
         if let Err(err) = connection.connect_configured(&ctx).await {
             error!(ctx, "{}", err);
             return;
@@ -200,11 +215,19 @@ async fn simple_imap_loop(
         }
     };
 
-    fut.race(stop_receiver.recv().map(|_| ())).await;
+    stop_receiver
+        .recv()
+        .map(|_| {
+            info!(ctx, "shutting down simple loop");
+        })
+        .race(fut)
+        .await;
     shutdown_sender.send(()).await;
 }
 
-async fn smtp_loop(ctx: Context, smtp_handlers: SmtpConnectionHandlers) {
+async fn smtp_loop(ctx: Context, started: Sender<()>, smtp_handlers: SmtpConnectionHandlers) {
+    use futures::future::FutureExt;
+
     info!(ctx, "starting smtp loop");
     let SmtpConnectionHandlers {
         mut connection,
@@ -213,7 +236,10 @@ async fn smtp_loop(ctx: Context, smtp_handlers: SmtpConnectionHandlers) {
         idle_interrupt_receiver,
     } = smtp_handlers;
 
+    let ctx1 = ctx.clone();
     let fut = async move {
+        started.send(()).await;
+        let ctx = ctx1;
         loop {
             let probe_network = ctx.scheduler.read().await.get_probe_network();
             match job::load_next(&ctx, Thread::Smtp, probe_network)
@@ -225,8 +251,6 @@ async fn smtp_loop(ctx: Context, smtp_handlers: SmtpConnectionHandlers) {
                     ctx.scheduler.write().await.set_probe_network(false);
                 }
                 Ok(None) | Err(async_std::future::TimeoutError { .. }) => {
-                    use futures::future::FutureExt;
-
                     // Fake Idle
                     async_std::task::sleep(Duration::from_millis(500))
                         .race(idle_interrupt_receiver.recv().map(|_| ()))
@@ -236,13 +260,19 @@ async fn smtp_loop(ctx: Context, smtp_handlers: SmtpConnectionHandlers) {
         }
     };
 
-    fut.race(stop_receiver.recv()).await.ok();
+    stop_receiver
+        .recv()
+        .map(|_| {
+            info!(ctx, "shutting down smtp loop");
+        })
+        .race(fut)
+        .await;
     shutdown_sender.send(()).await;
 }
 
 impl Scheduler {
     /// Start the scheduler, panics if it is already running.
-    pub fn run(&mut self, ctx: Context) {
+    pub async fn run(&mut self, ctx: Context) {
         let (mvbox, mvbox_handlers) = ImapConnectionState::new();
         let (sentbox, sentbox_handlers) = ImapConnectionState::new();
         let (smtp, smtp_handlers) = SmtpConnectionState::new();
@@ -254,23 +284,65 @@ impl Scheduler {
             sentbox,
             smtp,
             probe_network: false,
+            inbox_handle: None,
+            mvbox_handle: None,
+            sentbox_handle: None,
+            smtp_handle: None,
         };
 
+        let (inbox_start_send, inbox_start_recv) = channel(1);
+        if let Scheduler::Running { inbox_handle, .. } = self {
             let ctx1 = ctx.clone();
-        task::spawn(async move { inbox_loop(ctx1, inbox_handlers).await });
+            *inbox_handle = Some(task::spawn(async move {
+                inbox_loop(ctx1, inbox_start_send, inbox_handlers).await
+            }));
+        }
 
+        let (mvbox_start_send, mvbox_start_recv) = channel(1);
+        if let Scheduler::Running { mvbox_handle, .. } = self {
             let ctx1 = ctx.clone();
-        task::spawn(async move {
-            simple_imap_loop(ctx1, mvbox_handlers, "configured_mvbox_folder").await
-        });
+            *mvbox_handle = Some(task::spawn(async move {
+                simple_imap_loop(
+                    ctx1,
+                    mvbox_start_send,
+                    mvbox_handlers,
+                    "configured_mvbox_folder",
+                )
+                .await
+            }));
+        }
 
+        let (sentbox_start_send, sentbox_start_recv) = channel(1);
+        if let Scheduler::Running { sentbox_handle, .. } = self {
             let ctx1 = ctx.clone();
-        task::spawn(async move {
-            simple_imap_loop(ctx1, sentbox_handlers, "configured_sentbox_folder").await
-        });
+            *sentbox_handle = Some(task::spawn(async move {
+                simple_imap_loop(
+                    ctx1,
+                    sentbox_start_send,
+                    sentbox_handlers,
+                    "configured_sentbox_folder",
+                )
+                .await
+            }));
+        }
 
+        let (smtp_start_send, smtp_start_recv) = channel(1);
+        if let Scheduler::Running { smtp_handle, .. } = self {
             let ctx1 = ctx.clone();
-        task::spawn(async move { smtp_loop(ctx1, smtp_handlers).await });
+            *smtp_handle = Some(task::spawn(async move {
+                smtp_loop(ctx1, smtp_start_send, smtp_handlers).await
+            }));
+        }
+
+        // wait for all loops to be started
+        inbox_start_recv
+            .recv()
+            .try_join(mvbox_start_recv.recv())
+            .try_join(sentbox_start_recv.recv())
+            .try_join(smtp_start_recv.recv())
+            .await
+            .map(|_| ())
+            .unwrap_or_else(|err| error!(ctx, "failed to start scheduler: {}", err));
 
         info!(ctx, "scheduler is running");
     }
@@ -365,7 +437,18 @@ impl Scheduler {
             Scheduler::Stopped => {
                 panic!("WARN: already stopped");
             }
-            Scheduler::Running { .. } => {
+            Scheduler::Running {
+                inbox_handle,
+                mvbox_handle,
+                sentbox_handle,
+                smtp_handle,
+                ..
+            } => {
+                inbox_handle.take().expect("inbox not started").await;
+                mvbox_handle.take().expect("mvbox not started").await;
+                sentbox_handle.take().expect("sentbox not started").await;
+                smtp_handle.take().expect("smtp not started").await;
+
                 *self = Scheduler::Stopped;
             }
         }