From 26959d5b75eab8bb6737950b5a6d0fd721ad5ed8 Mon Sep 17 00:00:00 2001 From: link2xt Date: Mon, 9 Oct 2023 03:29:58 +0000 Subject: [PATCH] test(python): fix flaky `test_set_get_group_image` Wait for one "Member added" message to be delivered before sending another text message. Otherwise they may be reordered by the mail server. --- python/tests/test_1_online.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/python/tests/test_1_online.py b/python/tests/test_1_online.py index c94e4a904..6b7e17472 100644 --- a/python/tests/test_1_online.py +++ b/python/tests/test_1_online.py @@ -1926,13 +1926,15 @@ def test_set_get_group_image(acfactory, data, lp): lp.sec("ac1: add ac2 to promoted group chat") chat.add_contact(ac2) # sends one message + lp.sec("ac2: wait for receiving member added message from ac1") + msg1 = ac2._evtracker.wait_next_incoming_message() + assert msg1.is_system_message() # Member added + lp.sec("ac1: send a first message to ac2") chat.send_text("hi") # sends another message assert chat.is_promoted() lp.sec("ac2: wait for receiving message from ac1") - msg1 = ac2._evtracker.wait_next_incoming_message() - assert msg1.is_system_message() # Member added msg2 = ac2._evtracker.wait_next_incoming_message() assert msg2.text == "hi" assert msg1.chat.id == msg2.chat.id