diff --git a/src/mimefactory.rs b/src/mimefactory.rs index 5ed9e5726..2d9821e55 100644 --- a/src/mimefactory.rs +++ b/src/mimefactory.rs @@ -1003,17 +1003,6 @@ impl<'a> MimeFactory<'a> { "Secure-Join".to_string(), "vg-member-added".to_string(), )); - // FIXME: Old clients require Secure-Join-Fingerprint header. Remove this - // eventually. - let fingerprint = Peerstate::from_addr(context, email_to_add) - .await? - .context("No peerstate found in db")? - .public_key_fingerprint - .context("No public key fingerprint in db for the member to add")?; - headers.protected.push(Header::new( - "Secure-Join-Fingerprint".into(), - fingerprint.hex(), - )); } } SystemMessage::GroupNameChanged => { diff --git a/src/param.rs b/src/param.rs index a9f5c1a42..6465c4443 100644 --- a/src/param.rs +++ b/src/param.rs @@ -84,7 +84,7 @@ pub enum Param { /// For Messages Arg2 = b'F', - /// For Messages + /// `Secure-Join-Fingerprint` header for `{vc,vg}-request-with-auth` messages. Arg3 = b'G', /// For Messages diff --git a/src/securejoin.rs b/src/securejoin.rs index e23d62644..6a75987bf 100644 --- a/src/securejoin.rs +++ b/src/securejoin.rs @@ -174,7 +174,6 @@ async fn send_alice_handshake_msg( context: &Context, contact_id: ContactId, step: &str, - fingerprint: Option, ) -> Result<()> { let mut msg = Message { viewtype: Viewtype::Text, @@ -184,9 +183,6 @@ async fn send_alice_handshake_msg( }; msg.param.set_cmd(SystemMessage::SecurejoinMessage); msg.param.set(Param::Arg, step); - if let Some(fp) = fingerprint { - msg.param.set(Param::Arg3, fp.hex()); - } msg.param.set_int(Param::GuaranteeE2ee, 1); chat::send_msg( context, @@ -334,7 +330,6 @@ pub(crate) async fn handle_securejoin_handshake( context, contact_id, &format!("{}-auth-required", &step[..2]), - None, ) .await .context("failed sending auth-required handshake message")?; @@ -480,14 +475,9 @@ pub(crate) async fn handle_securejoin_handshake( mime_message.timestamp_sent, ) .await?; - send_alice_handshake_msg( - context, - contact_id, - "vc-contact-confirm", - Some(fingerprint), - ) - .await - .context("failed sending vc-contact-confirm message")?; + send_alice_handshake_msg(context, contact_id, "vc-contact-confirm") + .await + .context("failed sending vc-contact-confirm message")?; inviter_progress(context, contact_id, 1000); } diff --git a/src/securejoin/bobstate.rs b/src/securejoin/bobstate.rs index 05e5d52be..cf5fa3baa 100644 --- a/src/securejoin/bobstate.rs +++ b/src/securejoin/bobstate.rs @@ -358,13 +358,13 @@ async fn send_handshake_message( // Sends the Secure-Join-Auth header in mimefactory.rs. msg.param.set(Param::Arg2, invite.authcode()); msg.param.set_int(Param::GuaranteeE2ee, 1); + + // Sends our own fingerprint in the Secure-Join-Fingerprint header. + let bob_fp = load_self_public_key(context).await?.fingerprint(); + msg.param.set(Param::Arg3, bob_fp.hex()); } }; - // Sends our own fingerprint in the Secure-Join-Fingerprint header. - let bob_fp = load_self_public_key(context).await?.fingerprint(); - msg.param.set(Param::Arg3, bob_fp.hex()); - // Sends the grpid in the Secure-Join-Group header. if let QrInvite::Group { ref grpid, .. } = invite { msg.param.set(Param::Arg4, grpid);