Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-04-28 19:06:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: Remove unsigned Chat-Group-* headers from Autocrypt-encrypted messages

Browse Source 
These headers are opportunistically protected, so if they appear in the unencrypted part, they are
probably added by a malicious server.
This commit is contained in:
iequidoo
2024-02-13 12:43:59 -03:00
committed by link2xt
parent 8d09291d1e
commit 1a1467f7cf
2 changed files with 40 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/mimeparser.rs
View File

@@ -348,9 +348,20 @@ impl MimeMessage {
gossip_headers,
)
.await?;
// Remove unsigned subject from messages displayed with padlock.
// See <https://github.com/deltachat/deltachat-core-rust/issues/1790>.
headers.remove("subject");
// Remove unsigned opportunistically protected headers from messages considered
// Autocrypt-encrypted / displayed with padlock.
// For "Subject" see <https://github.com/deltachat/deltachat-core-rust/issues/1790>.
for h in [
HeaderDef::Subject,
HeaderDef::ChatGroupId,
HeaderDef::ChatGroupName,
HeaderDef::ChatGroupNameChanged,
HeaderDef::ChatGroupAvatar,
HeaderDef::ChatGroupMemberRemoved,
HeaderDef::ChatGroupMemberAdded,
] {
headers.remove(h.get_headername());
}
}
// let known protected headers from the decrypted