encode_66bits_as_base64: use base64 crate

Cargo.lock

@@ -463,6 +463,7 @@ dependencies = [
  "addr 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)",
  "backtrace 0.3.33 (registry+https://github.com/rust-lang/crates.io-index)",
  "base64 0.10.1 (registry+https://github.com/rust-lang/crates.io-index)",
+ "byteorder 1.3.2 (registry+https://github.com/rust-lang/crates.io-index)",
  "cc 1.0.37 (registry+https://github.com/rust-lang/crates.io-index)",
  "charset 0.1.2 (registry+https://github.com/rust-lang/crates.io-index)",
  "chrono 0.4.7 (registry+https://github.com/rust-lang/crates.io-index)",

Cargo.toml

@@ -43,6 +43,7 @@ strum = "0.15.0"
 strum_macros = "0.15.0"
 thread-local-object = "0.1.0"
 backtrace = "0.3.33"
+byteorder = "1.3.1"
 
 [dev-dependencies]
 tempfile = "3.0"

src/dc_tools.rs

@@ -746,26 +746,18 @@ pub fn dc_create_id() -> String {
 ///    base64: 64 bit, 6 bits/character, length = 64/6 = 11 characters (plus 2 additional bits)
 /// Only the lower 2 bits of `fill` are used.
 fn encode_66bits_as_base64(v1: u32, v2: u32, fill: u32) -> String {
-    static CHARS: [u8; 65] = [
+    use byteorder::{BigEndian, WriteBytesExt};
-        65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87,
+
-        88, 89, 90, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112,
+    let mut wrapped_writer = Vec::new();
-        113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57,
+    {
-        45, 95, 0,
+        let mut enc = base64::write::EncoderWriter::new(&mut wrapped_writer, base64::URL_SAFE);
-    ];
+        enc.write_u32::<BigEndian>(v1).unwrap();
-    let ret = vec![
+        enc.write_u32::<BigEndian>(v2).unwrap();
-        CHARS[((v1 >> 26) & 0x3f) as usize],
+        enc.write_u8(((fill & 0x3) as u8) << 6).unwrap();
-        CHARS[((v1 >> 20) & 0x3f) as usize],
+        enc.finish().unwrap();
-        CHARS[((v1 >> 14) & 0x3f) as usize],
+    }
-        CHARS[((v1 >> 8) & 0x3f) as usize],
+    assert_eq!(wrapped_writer.pop(), Some('A' as u8)); // Remove last "A"
-        CHARS[((v1 >> 2) & 0x3f) as usize],
+    String::from_utf8(wrapped_writer).unwrap()
-        CHARS[(((v1 << 4) & 0x30) | ((v2 >> 28) & 0x0f)) as usize],
-        CHARS[((v2 >> 22) & 0x3f) as usize],
-        CHARS[((v2 >> 16) & 0x3f) as usize],
-        CHARS[((v2 >> 10) & 0x3f) as usize],
-        CHARS[((v2 >> 4) & 0x3f) as usize],
-        CHARS[(((v2 << 2) & 0x3c) | (fill & 0x03)) as usize],
-    ];
-    String::from_utf8(ret).unwrap()
 }
 
 pub unsafe fn dc_create_incoming_rfc724_mid(