configure: emit errors via DC_EVENT_CONFIGURE_PROGRESS

Node test expects progress to report either success or error
eventually.

Also update the error text expected by node test.

CHANGELOG.md

@@ -10,6 +10,7 @@
 - set a default error if NDN does not provide an error
 - python: avoid exceptions when messages/contacts/chats are compared with `None`
 - node: wait for the event loop to stop before destroying contexts #3431
+- emit configuration errors via event on failure #3433
 
 ### API-Changes
 - python: added `Message.get_status_updates()`  #3416

node/test/test.js

@@ -128,7 +128,7 @@ describe('Basic offline Tests', function () {
 
     await expect(
       context.configure({ addr: 'delta1@delta.localhost' })
-    ).to.eventually.be.rejectedWith('Please enter a password.')
+    ).to.eventually.be.rejectedWith('Missing (IMAP) password.')
     await expect(context.configure({ mailPw: 'delta1' })).to.eventually.be
       .rejected
 

src/configure.rs

@@ -75,6 +75,24 @@ impl Context {
             }))
             .await;
 
+        if let Err(err) = res.as_ref() {
+            progress!(
+                self,
+                0,
+                Some(
+                    stock_str::configuration_failed(
+                        self,
+                        // We are using Anyhow's .context() and to show the
+                        // inner error, too, we need the {:#}:
+                        format!("{:#}", err),
+                    )
+                    .await
+                )
+            );
+        } else {
+            progress!(self, 1000);
+        }
+
         self.free_ongoing().await;
 
         res
@@ -114,30 +132,10 @@ impl Context {
             }
         }
 
-        match success {
+        success?;
-            Ok(_) => {
+        self.set_config(Config::NotifyAboutWrongPw, Some("1"))
-                self.set_config(Config::NotifyAboutWrongPw, Some("1"))
+            .await?;
-                    .await?;
+        Ok(())
-                progress!(self, 1000);
-                Ok(())
-            }
-            Err(err) => {
-                progress!(
-                    self,
-                    0,
-                    Some(
-                        stock_str::configuration_failed(
-                            self,
-                            // We are using Anyhow's .context() and to show the
-                            // inner error, too, we need the {:#}:
-                            format!("{:#}", err),
-                        )
-                        .await
-                    )
-                );
-                Err(err)
-            }
-        }
     }
 }