back to two verification-check functions (#4966)

this pr keeps and refines documentation added in #4951, however, reverts
the api introduced by #4951
which turns out to be not useful for UI in practise:

UI anyway check for chat/no-chat beforehand,
so a simple condition in profiles as
`green_checkmark = chat_exist ? chat_is_protected() :
contact_is_verified()`
is more useful in practise and is waht UI need and did already in the
past. (https://github.com/deltachat/deltachat-android/pull/2836 shows a
detailed discussion)

(as a side effect, beside saving code,
this PR saves up to three database calls
(get contact from chat in UI to pass it to profile_is_verified(), get
chat from contact in core, load is_protected in core) - instead, core
can use already is_protected from already loaded chat object)

/me did check rust-tests, fingers crossed for python tests
/me should re-setup python tests on local machine at some point :)
This commit is contained in:
bjoern
2023-11-09 23:31:18 +01:00
committed by GitHub
parent 1856c622a1
commit 0ee68d1dfc
5 changed files with 15 additions and 49 deletions

View File

@@ -3743,8 +3743,9 @@ int dc_chat_can_send (const dc_chat_t* chat);
* if `verified_one_on_one_chats` setting is enabled.
*
* UI should display a green checkmark
* in the chat title and
* in the chat title,
* in the chatlist item
* and in the chat profile
* if chat protection is enabled.
*
* @memberof dc_chat_t
@@ -5052,12 +5053,9 @@ int dc_contact_is_blocked (const dc_contact_t* contact);
*
* If contact is verified
* UI should display green checkmark after the contact name
* in contact list items and
* in chat member list items.
*
* Do not use this function when displaying the contact profile view.
* Display green checkmark in the title of the contact profile
* if dc_contact_profile_is_verified() returns true.
* in contact list items,
* in chat member list items
* and in profiles if no chat with the contact exist (otherwise, use dc_chat_is_protected()).
*
* @memberof dc_contact_t
* @param contact The contact object.
@@ -5067,24 +5065,6 @@ int dc_contact_is_blocked (const dc_contact_t* contact);
int dc_contact_is_verified (dc_contact_t* contact);
/**
* Check if the contact profile title
* should contain a green checkmark.
* This indicates whether 1:1 chat with
* this contact has a green checkmark
* or will have if such chat is created.
*
* Use dc_contact_get_verified_id to display the verifier contact
* in the info section of the contact profile.
*
* @memberof dc_contact_t
* @param contact The contact object.
* @return 1=contact profile has a green checkmark in the title,
* 0=contact profile has no green checkmark in the title.
*/
int dc_contact_profile_is_verified (dc_contact_t* contact);
/**
* Return the contact ID that verified a contact.
*