From 0e45c2246f3851e941e5d25f76409a5e0f107871 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Kl=C3=A4hn?= <39526136+Septias@users.noreply.github.com> Date: Wed, 28 May 2025 17:43:05 +0200 Subject: [PATCH] fix: remove faulty test (#6880) The test was still WIP but got merged together with the fix. I suggest to keep the fix in main and add the test in a follow-up RP. The test should suffice becaues I tested it manually. --- deltachat-jsonrpc/typescript/package.json | 1 - deltachat-jsonrpc/typescript/test/basic.ts | 27 ---------------------- 2 files changed, 28 deletions(-) diff --git a/deltachat-jsonrpc/typescript/package.json b/deltachat-jsonrpc/typescript/package.json index c0801a739..85a286676 100644 --- a/deltachat-jsonrpc/typescript/package.json +++ b/deltachat-jsonrpc/typescript/package.json @@ -3,7 +3,6 @@ "dependencies": { "@deltachat/tiny-emitter": "3.0.0", "isomorphic-ws": "^4.0.1", - "tmp": "^0.2.3", "yerpc": "^0.6.2" }, "devDependencies": { diff --git a/deltachat-jsonrpc/typescript/test/basic.ts b/deltachat-jsonrpc/typescript/test/basic.ts index 9e29119a2..b3ba3b6fa 100644 --- a/deltachat-jsonrpc/typescript/test/basic.ts +++ b/deltachat-jsonrpc/typescript/test/basic.ts @@ -1,6 +1,5 @@ import chai, { assert, expect } from "chai"; import chaiAsPromised from "chai-as-promised"; -import { fileSync } from "tmp"; chai.use(chaiAsPromised); import { StdioDeltaChat as DeltaChat } from "../deltachat.js"; @@ -100,32 +99,6 @@ describe("basic tests", () => { }); }); - describe("webxdc", function () { - let invalidXdcPath: string; - let accountId: number; - - before(async () => { - const tmpFile = fileSync({ postfix: ".xdc" }); - invalidXdcPath = tmpFile.name; - accountId = await dc.rpc.addAccount(); - }); - - it("should be able to draft set an invalid xdc", async function () { - const chat = await dc.rpc.createGroupChat(accountId, "xdc", false); - await expect( - dc.rpc.miscSetDraft( - accountId, - chat, - "", - invalidXdcPath, - "invalid.xdc", - null, - null - ) - ).to.be.eventually.rejectedWith("Invalid xdc"); - }); - }); - describe("configuration", function () { let accountId: number; before(async () => {