From 0b810d7d6549b69fdc1e9cc0da5c9d7f03c96041 Mon Sep 17 00:00:00 2001 From: Floris Bruynooghe Date: Tue, 28 Dec 2021 13:28:11 +0100 Subject: [PATCH] Run CI with -Dwarnings This runs all CI jobs with -Dwarnings, turning warnings into errors for CI. This is useful since we run rustfmt and clippy on CI on stable rust, while the builds and tests run with a specific older rustc. The latter is also used for local development usually since it is encoded in the rust-toolchain file. This warnings in clippy jobs of stable rust would often go unnoticed, however stable rust usually finds more genuine issues than the older compiler we use. --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 90079bafa..9c020143f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,6 +8,9 @@ on: - staging - trying +env: + RUSTFLAGS: -Dwarnings + jobs: fmt: @@ -103,8 +106,6 @@ jobs: - name: check uses: actions-rs/cargo@v1 - env: - RUSTFLAGS: -D warnings with: command: check args: --all --bins --examples --tests --features repl --benches