Remove deaddrop chat

Contact request chats are not merged into a single virtual "deaddrop"
chat anymore. Instead, they are shown in the chatlist the same way as
other chats, but sending of messages to them is not allowed and MDNs
are not sent automatically until the chat is "accepted" by the user.

New API:
- dc_chat_is_contact_request(): returns true if chat is a contact
request.  In this case option to accept and block the chat via
dc_accept_chat() and dc_block_chat() should be shown in the UI.
- dc_accept_chat(): accept contact request and unblock the chat
- dc_block_chat(): decline contact request and block the chat

Removed API:
- dc_create_chat_by_msg_id(): deprecated 2021-02-07 in favor of
  dc_decide_on_contact_request()
- dc_marknoticed_contact(): deprecated 2021-02-07 in favor of
  dc_decide_on_contact_request()
- dc_decide_on_contact_request(): this call requires a message ID from
  deaddrop chat as input. As deaddrop chat is removed, this call can't
  be used anymore.
- dc_msg_get_real_chat_id(): use dc_msg_get_chat_id() instead, the
  only difference between these calls was in handling of deaddrop chat
- removed DC_CHAT_ID_DEADDROP and DC_STR_DEADDROP constants

deltachat-ffi/src/lib.rs

@@ -642,23 +642,6 @@ pub unsafe extern "C" fn dc_get_chatlist(
     })
 }
 
-#[no_mangle]
-pub unsafe extern "C" fn dc_create_chat_by_msg_id(context: *mut dc_context_t, msg_id: u32) -> u32 {
-    if context.is_null() {
-        eprintln!("ignoring careless call to dc_create_chat_by_msg_id()");
-        return 0;
-    }
-    let ctx = &*context;
-
-    block_on(async move {
-        chat::create_by_msg_id(&ctx, MsgId::new(msg_id))
-            .await
-            .log_err(ctx, "Failed to create chat from msg_id")
-            .map(|id| id.to_u32())
-            .unwrap_or(0)
-    })
-}
-
 #[no_mangle]
 pub unsafe extern "C" fn dc_create_chat_by_contact_id(
     context: *mut dc_context_t,
@@ -1175,8 +1158,39 @@ pub unsafe extern "C" fn dc_delete_chat(context: *mut dc_context_t, chat_id: u32
         ChatId::new(chat_id)
             .delete(&ctx)
             .await
-            .log_err(ctx, "Failed chat delete")
-            .unwrap_or(())
+            .ok_or_log_msg(ctx, "Failed chat delete");
+    })
+}
+
+#[no_mangle]
+pub unsafe extern "C" fn dc_block_chat(context: *mut dc_context_t, chat_id: u32) {
+    if context.is_null() {
+        eprintln!("ignoring careless call to dc_block_chat()");
+        return;
+    }
+    let ctx = &*context;
+
+    block_on(async move {
+        ChatId::new(chat_id)
+            .block(&ctx)
+            .await
+            .ok_or_log_msg(ctx, "Failed chat block");
+    })
+}
+
+#[no_mangle]
+pub unsafe extern "C" fn dc_accept_chat(context: *mut dc_context_t, chat_id: u32) {
+    if context.is_null() {
+        eprintln!("ignoring careless call to dc_accept_chat()");
+        return;
+    }
+    let ctx = &*context;
+
+    block_on(async move {
+        ChatId::new(chat_id)
+            .accept(&ctx)
+            .await
+            .ok_or_log_msg(ctx, "Failed chat accept");
     })
 }
 
@@ -1569,17 +1583,6 @@ pub unsafe extern "C" fn dc_forward_msgs(
     })
 }
 
-#[no_mangle]
-pub unsafe extern "C" fn dc_marknoticed_contact(context: *mut dc_context_t, contact_id: u32) {
-    if context.is_null() {
-        eprintln!("ignoring careless call to dc_marknoticed_contact()");
-        return;
-    }
-    let ctx = &*context;
-
-    block_on(Contact::mark_noticed(&ctx, contact_id))
-}
-
 #[no_mangle]
 pub unsafe extern "C" fn dc_markseen_msgs(
     context: *mut dc_context_t,
@@ -2530,6 +2533,16 @@ pub unsafe extern "C" fn dc_chat_get_visibility(chat: *mut dc_chat_t) -> libc::c
     }
 }
 
+#[no_mangle]
+pub unsafe extern "C" fn dc_chat_is_contact_request(chat: *mut dc_chat_t) -> libc::c_int {
+    if chat.is_null() {
+        eprintln!("ignoring careless call to dc_chat_is_contact_request()");
+        return 0;
+    }
+    let ffi_chat = &*chat;
+    ffi_chat.chat.is_contact_request() as libc::c_int
+}
+
 #[no_mangle]
 pub unsafe extern "C" fn dc_chat_is_unpromoted(chat: *mut dc_chat_t) -> libc::c_int {
     if chat.is_null() {
@@ -2731,16 +2744,6 @@ pub unsafe extern "C" fn dc_msg_get_chat_id(msg: *mut dc_msg_t) -> u32 {
     ffi_msg.message.get_chat_id().to_u32()
 }
 
-#[no_mangle]
-pub unsafe extern "C" fn dc_msg_get_real_chat_id(msg: *mut dc_msg_t) -> u32 {
-    if msg.is_null() {
-        eprintln!("ignoring careless call to dc_msg_get_real_chat_id()");
-        return 0;
-    }
-    let ffi_msg = &*msg;
-    ffi_msg.message.get_real_chat_id().to_u32()
-}
-
 #[no_mangle]
 pub unsafe extern "C" fn dc_msg_get_viewtype(msg: *mut dc_msg_t) -> libc::c_int {
     if msg.is_null() {
@@ -3096,32 +3099,6 @@ pub unsafe extern "C" fn dc_msg_get_videochat_url(msg: *mut dc_msg_t) -> *mut li
         .strdup()
 }
 
-#[no_mangle]
-pub unsafe extern "C" fn dc_decide_on_contact_request(
-    context: *mut dc_context_t,
-    msg_id: u32,
-    decision: libc::c_int,
-) -> u32 {
-    if context.is_null() || msg_id <= constants::DC_MSG_ID_LAST_SPECIAL as u32 {
-        eprintln!("ignoring careless call to dc_decide_on_contact_request()");
-    }
-    let ctx = &*context;
-
-    match from_prim(decision) {
-        None => {
-            warn!(ctx, "{} is not a valid decision, ignoring", decision);
-            0
-        }
-        Some(d) => block_on(message::decide_on_contact_request(
-            ctx,
-            MsgId::new(msg_id),
-            d,
-        ))
-        .unwrap_or_default()
-        .to_u32(),
-    }
-}
-
 #[no_mangle]
 pub unsafe extern "C" fn dc_msg_get_videochat_type(msg: *mut dc_msg_t) -> libc::c_int {
     if msg.is_null() {